Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix some warnings and errors under C++20 #2078

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

Ralender
Copy link
Contributor

@Ralender Ralender commented Jul 9, 2020

Fixed a compile error under C++20.
Fixed multiple warnings and oddities

@elizabethandrews
Copy link
Contributor

The SemaSYCL changes look ok to me, but can you update the PR description with what error/warnings were fixed.

bader
bader previously approved these changes Jul 9, 2020
Copy link
Contributor

@rbegam rbegam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please resolve the conflicts.

@keryell
Copy link
Contributor

keryell commented Jul 10, 2020

Just for some context, this comes from triSYCL/sycl#76 where our own runtime is using C++20.
@Ralender: I have the feeling that you have not addressed all the messages like

llvm/sycl/include/CL/sycl/handler.hpp:572:57: warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Wdeprecated]
  572 |                                     IsPHSrc, IsPHDst>> ([=]() {

which appear when compiling with g++-9 and g++-10.
And while you are here you can remove the useless () in the lambda.

@bader bader merged commit 3f58ec4 into intel:sycl Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants