Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][CUDA] XFAIL the root_group barrier test for Cuda until it is implemented correctly #14461

Closed
wants to merge 1 commit into from
Closed

[SYCL][CUDA] XFAIL the root_group barrier test for Cuda until it is implemented correctly #14461

wants to merge 1 commit into from

Conversation

GeorgeWeb
Copy link
Contributor

The root group barrier support for Cuda is currently being worked on but we need this test to not fail in the CI for now in order to get other related functionality through. For example, see oneapi-src/unified-runtime#1796.

@GeorgeWeb GeorgeWeb requested a review from a team as a code owner July 5, 2024 13:21
@GeorgeWeb GeorgeWeb requested a review from bso-intel July 5, 2024 13:21
@GeorgeWeb
Copy link
Contributor Author

@intel/llvm-reviewers-runtime / @bso-intel . That's fairly important to unblock the unified-runtime feature implementation linked in the description. Thank you!

@maarquitos14
Copy link
Contributor

Can you please open a github issue to reenable the test when the known issue is solved? Otherwise we will lose track of this and might forget about it.

@GeorgeWeb
Copy link
Contributor Author

GeorgeWeb commented Jul 5, 2024 •
edited
Loading

Can you please open a github issue to reenable the test when the known issue is solved? Otherwise we will lose track of this and might forget about it.

@maarquitos14 You've got a point yeah! We are tracking this internally in oneAPI Core but being explicit about it won't hurt.

It is not failing at the moment but will be with the changes coming from oneapi-src/unified-runtime#1796. Do you suggest I link that in the gh issue description to make it a little more clear?

Update: I created the issue: #14462

@GeorgeWeb GeorgeWeb mentioned this pull request Jul 5, 2024
Closed
maarquitos14
maarquitos14 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GeorgeWeb GeorgeWeb closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@bso-intel bso-intel Awaiting requested review from bso-intel bso-intel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeWeb @maarquitos14