-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depl: drop capabilities from all plugins #1945
Conversation
Signed-off-by: Tuomas Katila <[email protected]>
a5f5553
to
74006cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise seems fine, but controllers are missing allowPrivilegeEscalation: false
setting from securityContext
. Deployments use it, so I assume controllers can too.
Controllers take the deployment as base: So any changes done in the deployments are inherited by the controllers. The tests failed in my first push as I didn't remember to add the _test.go changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
FPGA test is failing, but it's scheduling issue, not related to these changes:
0/2 nodes are available: 1 Insufficient fpga.intel.com/arria10.dcp1.2-nlb0-orchestrated
LGTM. Added |
Thanks. I was planning to add the fixes tag when the tests pass and I convert this from draft to review. |
Fixes: #1841