Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: rework webhooks #1906

Merged
merged 1 commit into from
Nov 20, 2024
Merged

operator: rework webhooks #1906

merged 1 commit into from
Nov 20, 2024

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Nov 12, 2024 •
edited
Loading

the next controller-runtime drops deprecated webhook.Defaulter/Validator. Move to admission.CustomDefaulter/Validator

@mythi mythi force-pushed the PR-2024-024 branch 2 times, most recently from 12b749d to 1b68395 Compare November 12, 2024 14:55
@mythi
Copy link
Contributor Author

mythi commented Nov 13, 2024

mostly untested and could use a bit of help

build operator from this PR and test deploy modified samples (e.g., without Image and with an old version). observe the webhook logs look sane

@mythi mythi marked this pull request as ready for review November 13, 2024 09:34
@mythi mythi force-pushed the PR-2024-024 branch 2 times, most recently from 1c2ebd7 to 00a50ab Compare November 14, 2024 09:57
tkatila
tkatila approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

tkatila
tkatila approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less copy-paste 👍

eero-t
eero-t reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring! I think this reveals more code with non-relevant differences that could be shared between plugins though...

pkg/apis/deviceplugin/v1/iaadeviceplugin_webhook.go Show resolved Hide resolved
@mythi
Copy link
Contributor Author

mythi commented Nov 18, 2024

pushed an update since I had expectedImage set wrong (intel-x-image but it should be intel-x-plugin)

@mythi
operator: rework webhooks
c30e80b 
controller-runtime has deprecated webhook.Defaulter/Validator and they
will be removed in the next controller-runtime release.

Move deviceplugin webhooks to use admission.CustomDefaulter/Validator.
Common defaulter/validator types can serve all the plugins with only
plugin specific data initialized.

As part of the rework, move away from (the unmaintained) pkg/errors
to errors in Go standard library.

Signed-off-by: Mikko Ylinen <[email protected]>
@tkatila tkatila merged commit 8dd66f5 into intel:main Nov 20, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eero-t eero-t eero-t approved these changes

@tkatila tkatila tkatila approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh bart0sh is a code owner

@kad kad Awaiting requested review from kad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mythi @eero-t @tkatila