This repository has been archived by the owner on Jan 28, 2023. It is now read-only.
Improve Check Tool #473
Merged
Improve Check Tool #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the command options and corresponding output descriptions for check tool. * Use '-v' option to show version information, replacing the previous trivial function * Update README document Signed-off-by: Wenchao Wang <[email protected]>
Currently the result of failed check is returned as 1, which causes the
installer cannot read the failed reason exactly.
* Use the error code as the return value of check tool
- 0 means success
- Positive values mean the failed check (returns 1 when the command
line argument is invalid)
- Negative values mean runtime fault
* Support 11 system checks, each of which is indicated by a certain bit
in the positive error code. The return value may be the bitwise
combination of these failed status bits.
Signed-off-by: Wenchao Wang <[email protected]>
hyuan3
approved these changes
Oct 19, 2022
hyuan3
approved these changes
Oct 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve user experience of Check Tool