Use perfs output switching capability #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I combined some misc changes in the same commit. I can split them if you prefer. |
I don't mind, I can CR as a whole. But please rebase before I start |
alonbentamar
suggested changes
Jun 8, 2021
|
|
||
| def _dump(self) -> Path: | ||
| assert self.process is not None, "profiling not started!" | ||
| self.process.send_signal(signal.SIGUSR2) |
There was a problem hiding this comment.
Document what this does (and maybe add a link to the relevant perf docs)
|
Superseded by #113 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently for each snapshot we execute perf on
sleep {duration}. This PR replaces this with running perf without stopping and using the output switching capability to dump the recorded events on each snapshot.Motivation and Context
This should avoid enabling/disabling of perf events every
durationstep for each core.How Has This Been Tested?
Ran locally on Ubuntu 18 VM. Output files look ok.
Checklist: