Fix memory leak in dwc_xdci_core_init when core_handle is NULL #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If core_handle is NULL then the error exit path leaks the previous allocation of local_core_handle causing a memory leak. Instead, move the null check on core_handle to before the memory allocation to avoid this leak. Signed-off-by: Colin Ian King <[email protected]>
jeremy-compostella
added a commit
that referenced
this pull request
Nov 10, 2016
git log --pretty=format:"%h %ad | %s%d [%an]" origin/android/master..remotes/origin/abt/sandbox/jcompost/efiwrapper-pr3: ad0862a Thu Nov 10 10:30:12 2016 +0100 | Merge pull request #1 from ColinIanKing/master (HEAD, origin/abt/sandbox/jcompost/efiwrapper-pr3, github/master, github/master) [Jérémy Compostella] e18d1ad Mon Nov 7 20:36:52 2016 +0000 | Fix memory leak in dwc_xdci_core_init when core_handle is NULL [Colin Ian King] git diff --stat origin/android/master..remotes/origin/abt/sandbox/jcompost/efiwrapper-pr3: drivers/dw3/XdciDWC.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Change-Id: Iac91941087b37b11ea7c598e4811db66c869310d Tracked-On: https://jira01.devtools.intel.com/browse/OAM-40038 Signed-off-by: Jeremy Compostella <[email protected]> Reviewed-on: https://android.intel.com:443/551290
xihua-chen
pushed a commit
that referenced
this pull request
Sep 11, 2019
Fix memory leak in dwc_xdci_core_init when core_handle is NULL
xihua-chen
pushed a commit
that referenced
this pull request
Sep 11, 2019
git log --pretty=format:"%h %ad | %s%d [%an]" origin/android/master..remotes/origin/abt/sandbox/jcompost/efiwrapper-pr3: ad0862a Thu Nov 10 10:30:12 2016 +0100 | Merge pull request #1 from ColinIanKing/master (HEAD, origin/abt/sandbox/jcompost/efiwrapper-pr3, github/master, github/master) [Jérémy Compostella] e18d1ad Mon Nov 7 20:36:52 2016 +0000 | Fix memory leak in dwc_xdci_core_init when core_handle is NULL [Colin Ian King] git diff --stat origin/android/master..remotes/origin/abt/sandbox/jcompost/efiwrapper-pr3: drivers/dw3/XdciDWC.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Change-Id: Iac91941087b37b11ea7c598e4811db66c869310d Tracked-On: OAM-40038 Signed-off-by: Jeremy Compostella <[email protected]> Reviewed-on: 551290
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If core_handle is NULL then the error exit path leaks the previous
allocation of local_core_handle causing a memory leak. Instead,
move the null check on core_handle to before the memory allocation
to avoid this leak.
Signed-off-by: Colin Ian King [email protected]