Skip to content

Commit

Permalink
drm/xe/display: fix i915_gem_object_is_shmem() wrapper
Browse files Browse the repository at this point in the history
shmem ensures the memory is cleared on allocation, however here we are
using TTM, which doesn't natively support shmem (other than for swap),
but instead just allocates normal system memory. And we only zero such
memory for userspace allocations. In the case of intel_fbdev we are
missing the memset_io() since display path incorrectly thinks object is
shmem based.

Fixes: 44e6949 ("drm/xe/display: Implement display support")
Signed-off-by: Matthew Auld <[email protected]>
Reviewed-by: Suraj Kandpal <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
(cherry picked from commit 63fb531)
Signed-off-by: Thomas Hellström <[email protected]>
  • Loading branch information
matt-auld authored and Thomas Hellström committed Feb 15, 2024
1 parent 9377de4 commit c2626b7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#include "xe_bo.h"

#define i915_gem_object_is_shmem(obj) ((obj)->flags & XE_BO_CREATE_SYSTEM_BIT)
#define i915_gem_object_is_shmem(obj) (0) /* We don't use shmem */

static inline dma_addr_t i915_gem_object_get_dma_address(const struct xe_bo *bo, pgoff_t n)
{
Expand Down

0 comments on commit c2626b7

Please sign in to comment.