Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify primitives + remove bin2 #267

Merged
merged 4 commits into from
Jun 23, 2021
Merged

Unify primitives + remove bin2 #267

merged 4 commits into from
Jun 23, 2021

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Jun 8, 2021

  • move substratee-node-/substratee-worker-primitives to primitives folder
  • remove bin2 folder. It is no longer necessary because the launch script with multiple workers creates the working directories.

@clangenb clangenb mentioned this pull request Jun 8, 2021
Merged
@clangenb clangenb requested a review from brenzi June 21, 2021 14:59
@brenzi brenzi merged commit e49df8e into master Jun 23, 2021
@clangenb clangenb deleted the unify-primitives branch June 24, 2021 09:02
brenzi pushed a commit that referenced this pull request Jun 29, 2021
@clangenb
Api client extensions: SubstrateeRegistryApi + AcountApi + ChainApi (#…
3f4bc86 
…268)

Add api client extensions.

I introduced this now with the testing in mind while developing/testing the broadcasting of sidechain blocks.

Because: Having the node-api behind a trait allows introducing easily a `MockApi` that returns hard-coded answers. 

**Note:** Merge #267 first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brenzi brenzi brenzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clangenb @brenzi