Add nonce validation to trusted calls #225
Conversation
* add trusted getter for nonce * exchange get_nonce client function with trusted getter * remove obsolete system api * remove pool validation (state must not be loaded for every tx)
|
All issues above should now be fixed in my opinion. The only thing missing is your proposal of the local storage of the nonce within the client. I opened issue #231 accordingly. Should we treat this as an seperate issue or do you want this to be included in this PR first? |
stf/src/sgx.rs
Outdated
| } else { | ||
| debug!("sender balance is zero"); | ||
| ext.execute_with(|| { | ||
| let mut root_account = AccountId::default(); |
There was a problem hiding this comment.
why do you use the term root if it isn't meant as superuser? Why don't you clone the account in-place?
There was a problem hiding this comment.
fixed with commit 7f33b2a
stf/src/sgx.rs
Outdated
| let result = match call.call { | ||
| TrustedCall::balance_set_balance(root, who, free_balance, reserved_balance) => { | ||
| root_account = root.clone(); | ||
| validate_nonce(&root_account, call.nonce)?; |
There was a problem hiding this comment.
why don't you do this before match?
It is a convention that the first argument of a TrustedCall is the caller's accountid, so you don't actually need to know what call it is to extract the accountid I guess?
There was a problem hiding this comment.
not sure if the problem is different number of arguments for enum values.....is there a idiomatic solution?
There was a problem hiding this comment.
fixed with commit 7f33b2a
closes #89
and some bug fixes (unit tests & block.rs went missing somewhere in the merging process..)