Fix bug with bool flags on subcommands #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error for valid bool flags "expected a following arg for flag <flag>, but it did not exist" The fix is to check flags on all nested subcommands when determining if a flag is a bool
|
Whoa. I'll test this tonight and merge if it looks good - I am surprised something like this snuck through tests. Thank you! |
integrii
approved these changes
Jan 14, 2020
|
Looks great! Nice work finding the right place and way to solve this problem in the codebase on your first try. Flaggy's code isn't always easy to follow, being a large recursive string parser. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error for valid bool flags "expected a following arg for flag , but it did not exist"
The fix is to check flags on all nested subcommands when determining if a flag is a bool
This fixes issue #57