data_source/github_repositories: add sort capabilities #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
Type: Documentation
tracypholmes
requested review from
a team
and removed request for
bflad,
ryndaniels,
nywilken and
mbfrahry
katbyte
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
Thanks for the updates @tracypholmes, I've left some minor comments inline that are mostly stylistic. Once those are addressed and tests pass this should be good to go 👍
Co-Authored-By: kt <[email protected]>
Co-Authored-By: kt <[email protected]>
…vider-github into f-github_repositories-sort-argument
--- PASS: TestAccGithubRepositoriesDataSource_basic (2.21s) --- PASS: TestAccGithubRepositoriesDataSource_Sort (25.97s) --- PASS: TestAccGithubRepositoriesDataSource_noMatch (1.60s)
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…#234) * data_source/github_repositories: add sort capabilities * updates docs * Update website/docs/d/repositories.html.markdown Co-Authored-By: kt <[email protected]> * Update github/data_source_github_repositories_test.go Co-Authored-By: kt <[email protected]> * reverts '%q' back to '"%s"' --- PASS: TestAccGithubRepositoriesDataSource_basic (2.21s) --- PASS: TestAccGithubRepositoriesDataSource_Sort (25.97s) --- PASS: TestAccGithubRepositoriesDataSource_noMatch (1.60s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206 and added ability to sort