Update groq.md #651
Merged
Update groq.md #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to de98621
- Looked at
21lines of code in1files - Took 43 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of85%.
Workflow ID: wflow_h7K6qRPpv8yB5Gyb
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
| @@ -51,7 +51,7 @@ client = Groq( | |||
| ) | |||
|
|
|||
| # By default, the patch function will patch the ChatCompletion.create and ChatCompletion.create methods to support the response_model parameter | |||
There was a problem hiding this comment.
The comment on this line still refers to OpenAI's ChatCompletion.create method, which might be misleading given the context switch to Groq. Please update the comment to reflect the use of Groq's client.
boydgreenfield
pushed a commit
to boydgreenfield/instructor
that referenced
this pull request
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructor now has a seperate groq client that should be used
Summary:
Updated the
groq.mddocumentation to utilize the newgroqspecific client with JSON mode for better data handling.Key points:
groq.mdto useinstructor.from_groqinstead ofinstructor.from_openai.MD_JSONtoJSON.Generated with ❤️ by ellipsis.dev