fixes retry_async message unpacking

[bradenkinard]

This fixes #174 by applying the same message appending logic as in the hotfix made here for retry_sync.

Summary by CodeRabbit

• Refactor
  • Improved error handling and message storage in the retry mechanism for asynchronous operations.

[coderabbitai]

Walkthrough

The patch updates the retry_async function to fix a bug related to error handling. Specifically, it changes how messages are appended to a list within kwargs, addressing an issue with the OpenAI SDK update to 1.0 where the previous method of using dict(**response.choices[0].message) was no longer valid.

Changes

File	Change Summary
instructor/patch.py	Modified retry_async function to append response.choices[0].message directly to kwargs["messages"].

Assessment against linked issues (Beta)

Objective	Addressed	Explanation
Resolve a bug in retry_async related to ValidationError or JSONDecodeError handling due to OpenAI SDK update to 1.0 (174)	✅
Address the issue with dict(**response.choices[0].message) throwing an error (174)	✅
Apply a similar hotfix to retry_async as was previously applied to retry_sync (174)	✅

🐇 In the code's weave, a bug did hide,
Now fixed and patched with a coder's pride.
As autumn leaves fall, our software stands tall,
With every commit, we're improving it all! 🍂🔧

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 55efa8c and dd8f1fd.

Files selected for processing (1)

• instructor/patch.py (1 hunks)

Additional comments: 1

instructor/patch.py (1)

• 89-95: The change from using dict with ** unpacking to directly appending the message to kwargs["messages"] list is a simplification that should help avoid potential issues with unpacking and improve readability. However, ensure that response.choices[0].message is always available and that the structure of response is consistent with this expectation. If response.choices or response.choices[0].message could be None or not present, this could raise an AttributeError or IndexError. It might be necessary to add error handling for these cases.

Additionally, the message being appended is now just the response.choices[0].message, whereas previously it seems like a dictionary with role and content keys was being appended. Ensure that this change in the structure of the messages in kwargs["messages"] is intentional and does not affect downstream processing.

[jxnl]

thanks will add some more tests so this does not happen next time

[jxnl]

https://github.com/jxnl/instructor/releases/tag/0.3.4