Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo changes #1125

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: typo changes #1125

merged 1 commit into from
Oct 28, 2024

Conversation

nawed2611
Copy link
Contributor

@nawed2611 nawed2611 commented Oct 28, 2024

  • change seperate to separate
  • change visino to vision

Important

Fixes typos in extracting_tables.md, changing seperate to separate and visino to vision.

  • Documentation:
    • Corrected typo seperate to separate in extracting_tables.md.
    • Corrected typo visino to vision in extracting_tables.md.

This description was created by Ellipsis for 214b6a5. It will automatically update as commits are pushed.

- change `seperate` to `separate`
- change 'visino` to `vision`
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 214b6a5 in 31 seconds

More details
  • Looked at 31 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. docs/examples/extracting_tables.md:141
  • Draft comment:
    The word seperate should be corrected to separate. This typo appears multiple times in the file (lines 46, 89, and 141).
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is partially relevant because it mentions a typo correction that was made in the diff. However, it also refers to lines that were not changed in this diff, which violates the rule of commenting only on changes made in the diff.
    I might be overemphasizing the irrelevance of the comment to the diff changes. The comment does highlight a valid issue that was addressed in the diff, even if it also mentions other instances.
    The primary focus should be on whether the comment is about the changes in the diff. Since it partially addresses the changes, it has some relevance.
    The comment should be kept because it addresses a typo correction that was made in the diff, even though it also mentions other instances not changed in this diff.
2. docs/examples/extracting_tables.md:138
  • Draft comment:
    The word 'seperate' is misspelled. It should be 'separate'. This issue is also present on lines 213.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_u78lccahB3dJFviu


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@jxnl jxnl merged commit ae6847b into instructor-ai:main Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants