Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Jinja2 as a dependency #1084

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Added Jinja2 as a dependency #1084

merged 2 commits into from
Oct 17, 2024

Conversation

ivanleomk
Copy link
Collaborator

@ivanleomk ivanleomk commented Oct 17, 2024

Pyproject.toml has a missing jinja2 dependency at the moment that will cause a fresh installation to throw an error. This remedies the issue


Important

Add jinja2 as a dependency in pyproject.toml to prevent installation errors.

  • Dependencies:
    • Add jinja2 version ^3.1.4 to pyproject.toml to prevent installation errors due to missing dependency.
    • Update version to 1.6.1 in pyproject.toml.

This description was created by Ellipsis for f9bb7c1. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 10b94c3 in 6 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:22
  • Draft comment:
    Ensure that the Jinja2 version specified ("^3.1.4") is compatible with the other dependencies and the Python version (3.9) used in the project.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of Jinja2 as a dependency seems appropriate given the PR description. However, it's important to ensure that the version specified is compatible with other dependencies and the Python version used.
2. pyproject.toml:22
  • Draft comment:
    Ensure that the addition of Jinja2 as a dependency is reflected in the documentation, specifically in mkdocs.yml, as this is a library code change.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The addition of Jinja2 as a dependency in the pyproject.toml file is a library code change. Therefore, the documentation should be updated to reflect this change. I need to check if mkdocs.yml is updated accordingly.

Workflow ID: wflow_tuIpgpSKe8vTY2xk


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying instructor-py with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9bb7c1
Status: ✅  Deploy successful!
Preview URL: https://a75fdf3b.instructor-py.pages.dev
Branch Preview URL: https://add-jinja-dependency.instructor-py.pages.dev

View logs

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on f9bb7c1 in 11 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:3
  • Draft comment:
    The PR description mentions adding Jinja2 as a dependency, but the diff does not show this addition. Please ensure the correct changes are included in the diff.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_KqsrKdnBgoBvoYed


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@ivanleomk ivanleomk merged commit 52982f3 into main Oct 17, 2024
14 of 15 checks passed
@ivanleomk ivanleomk deleted the add-jinja-dependency branch October 17, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant