Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move mention of max_retries to the correct section #1017

Merged
merged 1 commit into from
Oct 4, 2024
Merged

docs: move mention of max_retries to the correct section #1017

merged 1 commit into from
Oct 4, 2024

Conversation

hartshorne
Copy link
Contributor

@hartshorne hartshorne commented Sep 24, 2024

Describe your changes

...

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • If it is a core feature, I have added documentation.

Important

Move mention of max_retries to the correct section in retrying.md.

  • Documentation:
    • Move mention of max_retries to the correct section in retrying.md for clarity.

This description was created by Ellipsis for 863dbfe. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 863dbfe in 7 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/concepts/retrying.md:41
  • Draft comment:
    The change correctly moves the mention of max_retries to the appropriate section, improving clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly moves the mention of max_retries to the appropriate section, improving the document's clarity.

Workflow ID: wflow_QJNIoYH9Vwyqk92U


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@jxnl jxnl merged commit c9c36a5 into instructor-ai:main Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants