Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): revert to use http header callback for Authorization #193

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Oct 5, 2023

Because

  • refresh token isn't refreshed when access token is expired due to the http header Authorization callback was overridden

This commit

  • revert back to the previous logic
  • enable non-blocking status checks

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bbffb8b) 51.66% compared to head (74f4f9f) 51.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   51.66%   51.63%   -0.04%     
==========================================
  Files          61       61              
  Lines        4862     4846      -16     
==========================================
- Hits         2512     2502      -10     
+ Misses       2056     2053       -3     
+ Partials      294      291       -3     
Flag Coverage Δ
unittests 51.63% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cmd/api/api.go 70.53% <100.00%> (+0.36%) ⬆️
pkg/cmd/factory/http.go 75.86% <100.00%> (ø)
pkg/cmd/root/root.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinglin pinglin merged commit e39c3cf into main Oct 6, 2023
@pinglin pinglin deleted the pinglin/revert-http-header-callback branch October 6, 2023 00:02
pinglin added a commit that referenced this pull request Oct 6, 2023
Because

- refresh token isn't refreshed when access token is expired due to the
http header `Authorization` callback was overridden

This commit

- revert back to the previous logic
- enable non-blocking status checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants