Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(local): remove deploy path argument #192

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Oct 4, 2023

Because

  • the Instill Core projects can be just cloned to a constant local folder default to ~/.local/instill

This commit

  • remove path argument for deploy command
  • fix Makefile uninstall
  • update issue url

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f04b047) 51.58% compared to head (dc53a13) 51.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   51.58%   51.69%   +0.11%     
==========================================
  Files          61       61              
  Lines        4872     4865       -7     
==========================================
+ Hits         2513     2515       +2     
+ Misses       2064     2056       -8     
+ Partials      295      294       -1     
Flag Coverage Δ
unittests 51.69% <66.66%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/cmd/local/deploy.go 65.83% <100.00%> (-0.83%) ⬇️
pkg/cmd/local/status.go 73.72% <ø> (+1.82%) ⬆️
pkg/cmd/root/root.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pinglin pinglin force-pushed the pinglin/chore-clean-code branch 2 times, most recently from aa259e9 to c66cc77 Compare October 4, 2023 21:08
@pinglin pinglin force-pushed the pinglin/chore-clean-code branch from c66cc77 to d3b36f2 Compare October 4, 2023 21:34
@pinglin pinglin force-pushed the pinglin/chore-clean-code branch 6 times, most recently from 6669539 to ee3cf29 Compare October 4, 2023 22:23
@pinglin pinglin force-pushed the pinglin/chore-clean-code branch from ee3cf29 to dc53a13 Compare October 4, 2023 22:30
@pinglin pinglin merged commit 7b8c59b into main Oct 4, 2023
@pinglin pinglin deleted the pinglin/chore-clean-code branch October 4, 2023 22:39
pinglin added a commit that referenced this pull request Oct 4, 2023
Because

- the Instill Core projects can be just cloned to a constant local
folder default to `~/.local/instill`

This commit

- remove path argument for `deploy` command
- fix Makefile uninstall
- update issue url
pinglin added a commit that referenced this pull request Oct 4, 2023
Because

- the Instill Core projects can be just cloned to a constant local
folder default to `~/.local/instill`

This commit

- remove path argument for `deploy` command
- fix Makefile uninstall
- update issue url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants