-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multi instance support #178
feat: multi instance support #178
Conversation
INS-1661 CLI: multi-instance support
Later
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 50.13% 51.09% +0.96%
==========================================
Files 48 54 +6
Lines 3700 4196 +496
==========================================
+ Hits 1855 2144 +289
- Misses 1674 1833 +159
- Partials 171 219 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Tobias Cudnik <[email protected]> fix GH workflows Signed-off-by: Tobias Cudnik <[email protected]> fix GH workflows Signed-off-by: Tobias Cudnik <[email protected]> fix GH workflows Signed-off-by: Tobias Cudnik <[email protected]> fix GH workflows Signed-off-by: Tobias Cudnik <[email protected]> fix GH workflows Signed-off-by: Tobias Cudnik <[email protected]> ci: fix workflows - missing auth0 vars - .env for local dev - aligned build system - instill-dev.eu tenant working Signed-off-by: Tobias Cudnik <[email protected]> update go/mods Signed-off-by: Tobias Cudnik <[email protected]>
- wip: list cmd - table renderer - markdown output Signed-off-by: Tobias Cudnik <[email protected]>
- typed host config - list cmd - add cmd Signed-off-by: Tobias Cudnik <[email protected]>
- edit cmd - remove cmd - save config Signed-off-by: Tobias Cudnik <[email protected]>
- missing oauth fields - bound auth to config - default config on bootstrap Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
- fixed default hostname - fixed table urls - params validation Signed-off-by: Tobias Cudnik <[email protected]>
- `api` config integration Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
dbfb605
to
f32830e
Compare
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
- added `instances set-default` - fixed partial edits - re-fixed urls in tables (rebase) - fixed hostname parsing - dependabot updates Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments and suggested changes.
- imports - renames Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
@pinglin Ive implemented the renames and formatted imports. Im happy theres no concerns regarding the code itself. We should incorporate |
Yeah, that will be very ideal. @praharshjain has proposed and tried it before actually. Any guideline for this? |
This seems to be the right source: Import order should be linted, like any other required conventions. AFAIK we're using the default golangci-lint config. |
Signed-off-by: Tobias Cudnik <[email protected]>
Signed-off-by: Tobias Cudnik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Because - user can have more than 1 instance of Instill AI This commit - adds instance management and switching - instances management - `add`, `edit`, `list`, `remove`, `set-default` - markdown tables - tests - typed config (for hosts) - default config when empty - hostname validation - breaking dependabot updates - readme --------- Signed-off-by: Tobias Cudnik <[email protected]>
Because
This commit
Changes
add
,edit
,list
,remove
,set-default