Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize instance variables names when creating TonelReaderClassDefinition #130

Closed
eMaringolo opened this issue Jul 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request importing Issues related with importing from Tonel format portability Issues related with using Tonel between Smalltalk dialects

Comments

@eMaringolo
Copy link
Collaborator

Currently the instance variable names defined in in a Tonel class definition are instantiated parsing the literals with STON.

E.g.

Class {
	#name : #SBSActionableBadgeTag,
	#superclass : #SBSAnchorTag,
	#instVars : [
		#modifier,
		#contextStyle
	],
	#category : #'Bootstrap5-Core-Base'
}

But if the #instVars attribute defines the instance variable names as symbols, then this could cause issues when comparing with a VAST class that answers instances of Strings as a response to #instVarNames.

So it is better to normalize the elements in the collection to be instances of String when instantiating TonelReaderClassDefinition.

@eMaringolo eMaringolo added enhancement New feature or request portability Issues related with using Tonel between Smalltalk dialects importing Issues related with importing from Tonel format labels Jul 19, 2023
@eMaringolo eMaringolo self-assigned this Jul 19, 2023
eMaringolo added a commit that referenced this issue Jul 20, 2023
@eMaringolo
Copy link
Collaborator Author

Fixed by ddc7d9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request importing Issues related with importing from Tonel format portability Issues related with using Tonel between Smalltalk dialects
Projects
None yet
Development

No branches or pull requests

1 participant