Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import a new application edition if the current user is not the manager of the app #13

Open
gcotelli opened this issue Sep 9, 2019 · 2 comments
Assignees
Labels
bug Something isn't working importing Issues related with importing from Tonel format

Comments

@gcotelli
Copy link

gcotelli commented Sep 9, 2019

If you try to import an existing application and the logged user is not the same as the manager of the application you get a Walkback. (Even when MonticelloLoader appSuperGroupSetting: #world ) .
See attached stack trace:
Manager-stack.txt

Steps to reproduce:

  1. Create and version an application with the same of some app to import (by default it will be managed by LibrarySupervisor) and change the privileges so superGroup = #world.
  2. Create a new user and login with it
  3. Configure MonticelloLoader appSuperGroupSetting: #world
  4. Try importing a package that will end up in that application, and you will get something like: 'Base edition for BuoySUnitModel is managed by Supervisor. You are currently gcotelli and cannot create new editions of the application.'

It seems that the importer doesn't take into account the privileges, just check that the current user is the same as the application manager, even if the current user will have the required permissions to create and release editions in the app.

@eMaringolo eMaringolo self-assigned this Jan 3, 2020
@eMaringolo eMaringolo added bug Something isn't working importing Issues related with importing from Tonel format labels Jan 3, 2020
eMaringolo added a commit that referenced this issue Oct 28, 2020
@eMaringolo
Copy link
Collaborator

I did a few changes for supporting this.

If you evaluate this:

aTonelLoader settings appSuperGroupSetting: #world

It will honor the SuperGroup setting of the application when checking privileges, and also set the newly created edition with the setting defined in the TonelLoader or the previously existing setting if it's absent in the setting.

@eMaringolo
Copy link
Collaborator

Hi @gcotelli, we're doing a cleanup pass on pending issues and this seems already solved.
Did you try loading from a Tonel repository with the above mentioned setting?

eMaringolo added a commit that referenced this issue Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working importing Issues related with importing from Tonel format
Projects
None yet
Development

No branches or pull requests

2 participants