fix: ignored opentelemetry spans which are not traces by us #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kirrg001
commented
Dec 18, 2023
•
kirrg001
commented
- install any opentelemetry instrumentation inside the client / customer appliation + use our Instana collector
- it will add Otel spans for this instrumentation although we do not support it as part of our integration
- found this issue in feat: added azure blob instrumentation #967
kirrg001
force-pushed
the
fix/otel-integration
branch
from
dff4328 to
d599070
Compare
|
Azure SDK always installs a package called azure tracing. We should also check in #967 if the azure tracing package is somehow colliding with our Instana tracing. |
basti1302
approved these changes
Dec 20, 2023
aryamohanan
approved these changes
Dec 20, 2023
kirrg001
force-pushed
the
fix/otel-integration
branch
3 times, most recently
from
d0ef53e to
48e68a4
Compare
- install any opentelemetry instrumentation as a client dependency - and use our Instana collector - we will add Otel spans for this instrumentation although we do not support it as part of our integration
kirrg001
force-pushed
the
fix/otel-integration
branch
from
48e68a4 to
0b1b170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.