Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump serialize-error from 3.0.0 to 11.0.1 #844

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 14, 2023

Bumps serialize-error from 3.0.0 to 11.0.1.

Release notes

Sourced from serialize-error's releases.

v11.0.1

  • Fix handling of non-extensible objects fdfe034

sindresorhus/serialize-error@v11.0.0...v11.0.1

v11.0.0

Breaking

  • Expect a message property at a minimum to be interpreted as an Error (#77) 0720121

Improvements

  • Actually serialize nested errors (#73) 0af9fe8

sindresorhus/serialize-error@v10.0.0...v11.0.0

v10.0.0

Breaking

  • Require Node.js 14 22b9bd4
  • Preserve error constructor (#70) 49db63a
    • Previously it did not preserve built-in errors. It does now. So a TypeError might have been deserialized as a Error before, but is now deserialized as a TypeError.

Improvements

  • Deserialize nested errors (#69) bdf7ad4
  • Add useToJSON option (#71) e9e8666
  • Add isErrorLike() method (#68) bb6d9d6
  • Add support for cause property (#65) 7e8be51

sindresorhus/serialize-error@v9.1.1...v10.0.0

v9.1.1

  • Fix stream check (#60) 4eefe15

sindresorhus/serialize-error@v9.1.0...v9.1.1

v9.1.0

  • Handle streams attached to an error by replacing them with '[object Stream]' (#57) b589f8e

sindresorhus/serialize-error@v9.0.0...v9.1.0

v9.0.0

Breaking

  • Require Node.js 12.20 f698ea0
  • This package is now pure ESM. Please read this.

sindresorhus/serialize-error@v8.1.0...v9.0.0

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner August 14, 2023 19:15
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 14, 2023
@kirrg001
Copy link
Contributor

We could try to update to v8. See https://github.com/sindresorhus/serialize-error/blob/v8.0.0/package.json

dependabot bot and others added 2 commits August 22, 2023 14:16
Bumps [serialize-error](https://github.com/sindresorhus/serialize-error) from 3.0.0 to 11.0.1.
- [Release notes](https://github.com/sindresorhus/serialize-error/releases)
- [Commits](sindresorhus/serialize-error@v3.0.0...v11.0.1)

---
updated-dependencies:
- dependency-name: serialize-error
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@kirrg001 kirrg001 force-pushed the dependabot/npm_and_yarn/main/serialize-error-11.0.1 branch from b1950a9 to 3734b08 Compare August 22, 2023 12:29
@kirrg001 kirrg001 requested a review from basti1302 August 22, 2023 13:21
@kirrg001
Copy link
Contributor

@basti1302 There was a comment saying it is not possible to update serialize errors, but I think it is. Could you please double check? Thanks :)

P.s: Tests are failing because of AWS s3.

@basti1302
Copy link
Contributor

@basti1302 There was a comment saying it is not possible to update serialize errors, but I think it is. Could you please double check? Thanks :)

@kirrg001 This comment is from @willianpc, not from me. See https://github.com/instana/nodejs/pull/366/files#diff-4b27f44d9340c170c1f8a29266e4d570f0fb2a250cc92dc4480a9656b63a3d2dR12.

I am not entirely sure what it means. I think it is mostly about the typescript types for that package? Not sure if Willian actually saw any breakage in the code after trying to update.

I say if the tests are green, we can update to 8.x (but not beyond, due to the package moving to ESM).

@willianpc
Copy link
Contributor

willianpc commented Aug 23, 2023

@basti1302 There was a comment saying it is not possible to update serialize errors, but I think it is. Could you please double check? Thanks :)

@kirrg001 This comment is from @willianpc, not from me. See https://github.com/instana/nodejs/pull/366/files#diff-4b27f44d9340c170c1f8a29266e4d570f0fb2a250cc92dc4480a9656b63a3d2dR12.

I am not entirely sure what it means. I think it is mostly about the typescript types for that package? Not sure if Willian actually saw any breakage in the code after trying to update.

I say if the tests are green, we can update to 8.x (but not beyond, due to the package moving to ESM).

Oof, I don't quite remember what that is, but judging by the comment and the branch title, it is only about type checking.
That task was not about changing our code (even though I remember updating some things here and there to make TS happy).

As the comment is also about version of suff, there may be the case that newer versions solve whatever that thing is. But again, it seems to be only about type checking and not about the code.

I can take a deeper look if you want me to. Just give me a shout :)

@basti1302
Copy link
Contributor

I can take a deeper look if you want me to. Just give me a shout :)

IMHO that is not required.

@kirrg001 kirrg001 merged commit 5fa039c into main Aug 23, 2023
@kirrg001 kirrg001 deleted the dependabot/npm_and_yarn/main/serialize-error-11.0.1 branch August 23, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants