-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump serialize-error from 3.0.0 to 11.0.1 #844
build(deps): bump serialize-error from 3.0.0 to 11.0.1 #844
Conversation
We could try to update to v8. See https://github.com/sindresorhus/serialize-error/blob/v8.0.0/package.json |
Bumps [serialize-error](https://github.com/sindresorhus/serialize-error) from 3.0.0 to 11.0.1. - [Release notes](https://github.com/sindresorhus/serialize-error/releases) - [Commits](sindresorhus/serialize-error@v3.0.0...v11.0.1) --- updated-dependencies: - dependency-name: serialize-error dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
b1950a9
to
3734b08
Compare
@basti1302 There was a comment saying it is not possible to update serialize errors, but I think it is. Could you please double check? Thanks :) P.s: Tests are failing because of AWS s3. |
@kirrg001 This comment is from @willianpc, not from me. See https://github.com/instana/nodejs/pull/366/files#diff-4b27f44d9340c170c1f8a29266e4d570f0fb2a250cc92dc4480a9656b63a3d2dR12. I am not entirely sure what it means. I think it is mostly about the typescript types for that package? Not sure if Willian actually saw any breakage in the code after trying to update. I say if the tests are green, we can update to 8.x (but not beyond, due to the package moving to ESM). |
Oof, I don't quite remember what that is, but judging by the comment and the branch title, it is only about type checking. As the comment is also about version of suff, there may be the case that newer versions solve whatever that thing is. But again, it seems to be only about type checking and not about the code. I can take a deeper look if you want me to. Just give me a shout :) |
IMHO that is not required. |
Bumps serialize-error from 3.0.0 to 11.0.1.
Release notes
Sourced from serialize-error's releases.
... (truncated)
Commits
786f5eb
11.0.1fdfe034
Fix handling of non-extensible objectsa212a8c
Meta tweaks2a77169
11.0.00720121
Expect amessage
property at a minimum to be interpreted as an Error (#77)0af9fe8
Actually serialize nested errors (#73)6f6102f
10.0.022b9bd4
Require Node.js 1449db63a
Preserve error constructor (#70)bdf7ad4
Deserialize nested errors (#69)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)