feat: added support for sqs-consumer v8, v9 #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
commented
Mar 14, 2024
| @@ -209,7 +209,7 @@ | |||
| "sinon-chai": "^3.7.0", | |||
| "socket.io": "^4.6.0", | |||
| "socket.io-client": "^4.6.0", | |||
| "sqs-consumer": "^7.4.0", | |||
| "sqs-consumer": "^9.1.0", | |||
| "sqs-consumer-v5": "npm:sqs-consumer@^5.7.0", | |||
There was a problem hiding this comment.
NOTE: sqs-consumer-v5 is used by aws v2.
kirrg001
force-pushed
the
update-sqs-consumer
branch
from
dac3b53 to
105460f
Compare
|
v8 is already broken |
|
The underlying problem is #1076 |
refs 158386 [ci all-tests]
kirrg001
force-pushed
the
update-sqs-consumer
branch
from
105460f to
dd2fa98
Compare
|
@aryamohanan We can ship that on Monday as well. |
aryamohanan
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs 158386