Allow absolute path Fixes #24 #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eldwick
reviewed
Aug 14, 2017
| import themer from '../../styles/themer' | ||
| import zIndex from '../../styles/zIndex' | ||
| import { spacings } from '../../styles/spacing' | ||
| import colors from 'styles/colors' |
There was a problem hiding this comment.
Kinda feels like we should import every style related things in one line, eg:
import { colors, responsive, themer, zIndex, spacing } from 'styles'
There was a problem hiding this comment.
I agree, but this should probably be a separate issue all I did was change from a relative path to an absolute path
| import responsive from 'styles/responsive' | ||
| import themer from 'styles/themer' | ||
| import zIndex from 'styles/zIndex' | ||
| import { spacings } from 'styles/spacing' |
There was a problem hiding this comment.
If we do want to continue importing directly from the specific directory, this should mirror other style import conventions and be:
import spacings from 'styles/spacing'
|
Fixes #24 |
|
This looks good to me, but will need conflicts resolved. @nbwar can you resolve conflicts and then I can approve/merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use absolute path and changed components that used relative paths to absolute.
Also cleaned up some minor indenting and sorting of imports.