Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: fix rt ticket creation for harvests #3186

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

ammirate
Copy link
Contributor

@ammirate ammirate commented Feb 13, 2018

This fix this issue: https://sentry.inspirehep.net/inspire-sentry/prod/issues/12/

Checklist:

  • I have all the information that I need (if not, move to RFC and look for it).
  • I linked the related issue(s) in the corresponding commit logs.
  • I wrote good commit log messages.
  • My code follows the code style of this project.
  • I've added any new docs if API/utils methods were added.
  • I have updated the existing documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ammirate ammirate self-assigned this Feb 13, 2018
@ghost ghost added the Review: WIP label Feb 13, 2018
@ammirate
Copy link
Contributor Author

I have tested this manually on QA accepting records as core, and checking that tickets were created in inspirevm13.
Is there a way to test it locally?

@ammirate
Copy link
Contributor Author

I have mocked the RT requests in the workflow tests, this should be enough for now.

@ammirate
Copy link
Contributor Author

ci merge please

@inspire-bot inspire-bot merged commit 55cb137 into inspirehep:master Feb 14, 2018
inspire-bot pushed a commit that referenced this pull request Feb 14, 2018
@ghost ghost removed the Review: WIP label Feb 14, 2018
@ammirate ammirate deleted the rt_fix branch February 15, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants