-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getBestNapiBuildVersion() fails on Node 23.6.0 #6
Labels
bug
Something isn't working
Comments
jschlight
added a commit
that referenced
this issue
Jan 16, 2025
jschlight
added a commit
that referenced
this issue
Jan 16, 2025
jschlight
added a commit
that referenced
this issue
Jan 16, 2025
jschlight
added a commit
that referenced
this issue
Jan 16, 2025
jschlight
added a commit
that referenced
this issue
Jan 17, 2025
jschlight
added a commit
that referenced
this issue
Jan 17, 2025
This issue should now be addressed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Node 23.6.0 increased the napi version to
10
- the first napi version to have double digits. This causesgetBestNapiBuildVersion
(and perhaps other functions too) to fail to produce the correct version:The root cause is string comparison instead of numeric comparison - until we reached
10
, whennapiBuildVersion <= ourNapiVersion
compared strings, the result was the same as though they were numbers. Now its using lexographic comparison, andnapiBuildVersion <= ourNapiVersion
->'4' <= '10'
-> 'false'.The text was updated successfully, but these errors were encountered: