ProxyCommand support #227
Merged
ProxyCommand support #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeckr
force-pushed
the
proxy_command
branch
2 times, most recently
from
b5ee7c9 to
025894b
Compare
cbeckr
added a commit
to mes/inspec
that referenced
this pull request
Dec 10, 2017
NOTE This is just a simple wrapper which relies on the underlying support being added to train: inspec/train#227 Signed-off-by: Christian Becker <[email protected]>
cbeckr
force-pushed
the
proxy_command
branch
from
025894b to
3c9296f
Compare
…dy and Train::Transports::WinRM.wait_until_ready Signed-off-by: Christian Becker <[email protected]>
Signed-off-by: Christian Becker <[email protected]>
cbeckr
force-pushed
the
proxy_command
branch
from
3c9296f to
ee33440
Compare
|
@cbeckr - Thank you so much for your first contribution! Welcome to the family :) This looks great and I will test it out soon and get back to you! |
jquick
reviewed
Dec 14, 2017
| @@ -113,7 +114,7 @@ def wait_until_ready | |||
| message: "Waiting for SSH service on #{@hostname}:#{@port}, " \ | |||
| "retrying in #{delay} seconds", | |||
| ) | |||
| execute(PING_COMMAND.dup) | |||
| run_command(PING_COMMAND.dup) | |||
There was a problem hiding this comment.
I think we want to use the run_command_via_connection here instead. The run_command has the potential for caching which could cause unexpected results.
| @@ -80,7 +80,7 @@ def wait_until_ready | |||
| retry_limit: @max_wait_until_ready / delay, | |||
| retry_delay: delay, | |||
| ) | |||
| execute(PING_COMMAND.dup) | |||
| run_command(PING_COMMAND.dup) | |||
There was a problem hiding this comment.
Same as above, I think it would be safer to run_command_via_connection
jquick
approved these changes
Feb 13, 2018
|
I think this looks good for now, I plan on updating all the "wait_until_ready" flags as its like this on other transports also. |
cbeckr
added a commit
to mes/inspec
that referenced
this pull request
Feb 25, 2018
NOTE This is just a simple wrapper which relies on the underlying support being added to train: inspec/train#227 Signed-off-by: Christian Becker <[email protected]>
jquick
pushed a commit
to inspec/inspec
that referenced
this pull request
Mar 22, 2018
NOTE This is just a simple wrapper which relies on the underlying support being added to train: inspec/train#227 Signed-off-by: Christian Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for connecting via jump hosts.