Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename attributes options to input options #229

Merged
merged 8 commits into from
Jun 6, 2019

Conversation

clintoncwolfe
Copy link
Contributor

@clintoncwolfe clintoncwolfe commented Apr 9, 2019

Description

Supporting inspec/inspec#3802 , this renames the YAML keys used to set InSpec Inputs:

  • attrs => input_files
  • attributes => inputs

The old names are still supported but issue a warning. We probe the version of InSpec to determine what RunnerAPI keys to use, as those are to change, too.

Issues Resolved

Fixes #224

Check List

@clintoncwolfe clintoncwolfe added Aspect: Integration Works correctly with other projects or systems. Aspect: UI How users interact with the interface of the project, with a focus on interaction and visual design. Type: Enhancement Adds new functionality. Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. labels Apr 9, 2019
@clintoncwolfe clintoncwolfe requested review from tyler-ball and miah April 9, 2019 20:58

To run a profile with attributes defined inline, you can adapt your `.kitchen.yml`:
Note: InSpec Inputs were formerly known as InSpec Attributes. As they are not related to Chef Attributes, they have been renamed to reduce confusion.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe explicitly show the yaml diff for anyone who already use this and need to change their .kitchen.yml?

@clintoncwolfe clintoncwolfe force-pushed the cw/rename-attributes-option branch from 0c816f4 to cbba5a0 Compare June 5, 2019 16:18
@clintoncwolfe clintoncwolfe force-pushed the cw/rename-attributes-option branch from f68ae65 to ac84b5f Compare June 6, 2019 18:10
@clintoncwolfe clintoncwolfe merged commit 9c88256 into master Jun 6, 2019
@clintoncwolfe clintoncwolfe deleted the cw/rename-attributes-option branch June 6, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Integration Works correctly with other projects or systems. Aspect: UI How users interact with the interface of the project, with a focus on interaction and visual design. Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute->Input rename - send inputs to Inspec as using 'inputs' key
3 participants