Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and activate linting for CI #20

Merged
merged 6 commits into from
Dec 8, 2015
Merged

Fix tests and activate linting for CI #20

merged 6 commits into from
Dec 8, 2015

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Dec 7, 2015

...such that this doesn't fire. Fixes #19.

@srenatus srenatus added the bug label Dec 7, 2015
@chris-rock
Copy link
Collaborator

@srenatus Why does it fire an exit_status?

@srenatus
Copy link
Contributor Author

srenatus commented Dec 7, 2015

@chris-rock If runner.run doesn't return 0, an exception will be raised at the end of verifier.call() because the mock doesn't return anything unless told explicitly:

exit_code = runner.run
raise ActionFailed, "Inspec Runner returns #{exit_code}" unless exit_code == 0

This was added recently, I'm just adapting the tests.

...such that lib/kitchen/verifier/inspec.rb:57 doesn't fire
@chris-rock chris-rock changed the title make the mock return exit_status 0 Fix tests and activate linting for CI Dec 8, 2015
@chris-rock
Copy link
Collaborator

  • added inspec ruby styling
  • fixed lint errors
  • activated lint as default rake task

@arlimus
Copy link
Collaborator

arlimus commented Dec 8, 2015

This is a huge quality improvement, wow!! Excellent 🎊 @srenatus and @chris-rock 👍

arlimus added a commit that referenced this pull request Dec 8, 2015
Fix tests and activate linting for CI
@arlimus arlimus merged commit 04a7330 into master Dec 8, 2015
@arlimus arlimus deleted the sr/fix19 branch December 8, 2015 15:41
@tas50 tas50 added Type: Bug Doesn't work as expected. and removed bug labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Doesn't work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests fail with inspec 0.9.5
4 participants