-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the exec driver/transport #172
Conversation
There's not really any configuring to do. After mapping it to Inspec's local backend, it just works. Signed-off-by: Jonathan Hartman <[email protected]>
dcaa0d2
to
90f5059
Compare
Hey @RoboticCheese thanks for this PR! I have some questions about this implementation. If I understand this correctly we are just binding the runner to local backend which will actually test on the server running kitchen and not the targeted node created with kitchen(as your not using a transport to attach to the generated nodes). Can you lay out the use case for this? |
Your understanding is correct. The exec driver doesn't create any VMs, Docker containers, etc.; it just shells out on the local machine. The instance running Kitchen and the instance under test are one in the same. The only piece missing to get a successful verify is something mapping Kitchen's exec driver to Inspec's local backend. I'm not sure what other folks use the exec driver for, but I use it for cookbook testing in TravisCI's macOS build environment and Appveyor's Windows build environment. |
Anything needed on this to move forward? |
Great work @RoboticCheese You just saved me a bunch of time. Using local exec for kitchen-terraform provider with the inspec validator and working great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @RoboticCheese . Talked this over with the team and we will be using the 'local' keyword instead of 'exec' to remove confusion. I will create a follow up PR that will prefer and document the 'local' transport.
@RoboticCheese nice work! We should also document this behaviour in README. |
@chris-rock issue is here #204 |
There's not really any configuring to do. After mapping it to Inspec's local
backend, it just works.
Signed-off-by: Jonathan Hartman [email protected]