support test suite helpers #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schisamo
added a commit
to inspec/inspec
that referenced
this pull request
Nov 20, 2015
This change builds on inspec/kitchen-inspec#12. All test directories should be on the `$LOAD_PATH` when `Inspec::Runner` executes the test suites with `RSpec::Core::Runner`. This will allow things like `require 'spec_helper'` to work as expected.
schisamo
added a commit
to inspec/inspec
that referenced
this pull request
Nov 20, 2015
This change builds on inspec/kitchen-inspec#12. All test directories should be on the `$LOAD_PATH` when `Inspec::Runner` executes the test suites with `RSpec::Core::Runner`. This will allow things like `require 'spec_helper'` to work as expected.
|
👍 |
|
I talked with @arlimus's in depth about this feature. We are going to hold off on merging anything for now as they have some plans to address this soon. There will be an upcoming RFC that lays out the the various options. |
Test Kitchen's default verifier, Busser, has support for loading helper files which include things like: * spec_helper * InSpec custom resources * RSpec shared examples * RSpec shared contexts * RSpec custom matchers These helper files are meant to be shared amongst all test suites in a project structure like: ``` test/integration/ ├── helpers │ └── <VERIFIER> │ ├── spec_helper.rb │ └── support │ └── some_file.rb ├── suite1 │ └── <VERIFIER> │ └── some_spec.rb └── suite2 └── <VERIFIER> └── some_spec.rb ``` Some real world examples can be seen at: https://github.com/chef-cookbooks/jenkins/tree/master/test/integration https://github.com/chef-cookbooks/languages/tree/master/test/integration https://github.com/chef-cookbooks/omnibus/tree/master/test/integration This change ensures `Kitchen::Verifier::Inspec` fully supports these helper files!
chris-rock
force-pushed
the
schisamo/helpers-support
branch
from
6858b09 to
edc6d9f
Compare
|
Thanks @schisamo that helps us to ease the Serverspec migration |
|
Unlikely the latest version dropped support for helper files in inspec: https://github.com/chef/kitchen-inspec/blob/master/lib/kitchen/verifier/inspec.rb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Kitchen's default verifier, Busser, has support for loading helper files which include things like:
These helper files are meant to be shared amongst all test suites in a project structure like:
Some real world examples can be seen at:
https://github.com/chef-cookbooks/jenkins/tree/master/test/integration
https://github.com/chef-cookbooks/languages/tree/master/test/integration
https://github.com/chef-cookbooks/omnibus/tree/master/test/integration
This change ensures
Kitchen::Verifier::Inspecfully supports these helper files!/cc @chef/compliance @chef/engineering-services