Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the jsonAutomate report to be executed from cli #3285

Merged
merged 2 commits into from
Aug 15, 2018

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Aug 10, 2018

Signed-off-by: Jared Quick [email protected]

This change allows the A2 team or other reports to test the JsonMerged report used in A2. This change also allows us to easily replace the report type in the Audit cookbook.

Please not the JsonMerged already has a full test suite and this change is just allowing it to be accessed via the reporter cli flag.

Note this is intentionally undocumented for now.

@chris-rock
Copy link
Contributor

I am wondering if we should call this json-3 to indicate that this is becoming the default json reporter for inspec 3. Then we can also introduce json-2 to make the current json reporter available with InSpec 3 too. If users will rely on the old behavior, they just need to switch to the reporter.
@arlimus what do you think?

@jquick
Copy link
Contributor Author

jquick commented Aug 13, 2018

After talking this over we will update the name to json-automate as we may have additional automate info in the report.

@chris-rock
Copy link
Contributor

Please add comment, that this is for Chef internal and we reserve the right to introduce breaking changes to that reporter at any point. We also are not going to document the reporter in our public docs.

@alexpop
Copy link
Contributor

alexpop commented Aug 14, 2018

I pushed a small branch to the audit cookbook in prep for this change when it goes in:

https://github.com/chef-cookbooks/audit/compare/ap/chef-automate-reporter

@jquick jquick force-pushed the jq/add_json_merged_reporter branch from f6dca54 to 5c6e2e5 Compare August 14, 2018 15:20
@jquick jquick changed the title Allow the jsonMerged report to be executed from cli Allow the jsonAutomate report to be executed from cli Aug 14, 2018
@jquick jquick merged commit 34ac059 into master Aug 15, 2018
@jquick jquick deleted the jq/add_json_merged_reporter branch August 15, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants