elasticsearch resource #1956

rx294 · 2017-06-22T22:50:57Z

Documentation and Unit Tests

Signed-off-by: Rony Xavier [email protected]
Signed-off-by: Aaron Lippold [email protected]

Signed-off-by: Rony Xavier <[email protected]> Signed-off-by: Aaron Lippold <[email protected]>

adamleff

Hi, @rx294 - welcome to the InSpec community and thanks for your first PR!

I've left you some feedback - please don't hesitate to ask if you have any questions. Thanks!

adamleff · 2017-06-23T15:43:53Z

docs/resources/elasticsearch.md.erb

+* `{ should eq 'value' }` is the value that is expected
+
+## Supported Properties
+    * `'cluster_name'`, `'node_id'`, `'node_name'`,`'host'`, `'ip'`, `'version'`, `'build_hash'`


Can you just make each item a single bullet item, alphabetized? Makes it easier to read through and easier for a user to find what they're looking for.

adamleff · 2017-06-23T15:44:37Z

docs/resources/elasticsearch.md.erb

+### cluster_name ([String])
+
+    describe elasticsearch.where { node_name == 'package-centos-72' } do
+      its('cluster_name.first') { should match 'elasticsearch' }


Since the cmp matcher will change a single-element array to a non-array, I'd change this to:

its('cluster_name') { should cmp 'elasticsearch' }

adamleff · 2017-06-23T15:47:07Z

docs/resources/elasticsearch.md.erb

+    # Verify the version of the node that matches the name node2
+
+    describe elasticsearch.where { node_name == 'package-centos-72' } do
+      its('version.first') { should match '5.4.1' }


Again, I'd use the cmp matcher here rather than teaching users to use first

adamleff · 2017-06-23T15:47:28Z

lib/inspec/resource.rb

@@ -90,6 +90,7 @@ def self.validate_resource_dsl_version!(version)
 require 'resources/docker_image'
 require 'resources/docker_container'
 require 'resources/etc_group'
+require 'resources/elasticsearch.rb'


You can drop the .rb from this

adamleff · 2017-06-23T15:47:59Z

lib/resources/elasticsearch.rb

+module Inspec::Resources
+  class Elasticsearch < Inspec.resource(1)
+    name 'elasticsearch'
+    desc 'See Description below'


The desc contents are displayed in the inspec shell output... so there would be no description printed. Please uncomment similar to other resources.

adamleff · 2017-06-23T15:57:54Z

lib/resources/elasticsearch.rb

+
+    def parse_node_process(node)
+      {
+        'process'               => node,


This would cause the node hash to have a full copy of itself. Did you forget to set a key here?

adamleff · 2017-06-23T15:59:07Z

lib/resources/elasticsearch.rb

+    end
+
+    def to_s
+      'Elasticsearch Environment'


I think Environment is a loaded term... how about Elasticsearch ClusterInfo?

adamleff · 2017-06-23T16:00:44Z

www/Gemfile.lock

@@ -1,275 +0,0 @@
-PATH


Can you please revert this change from your commit? The Gemfile.lock for the www should remain, and if there is a desire to drop it, we should do that as a separate PR. Thanks!

Hey @adamleff, I have reorganized and made the recommended changes to this PR. I belive I have reverted the Gemfile.lock, please let me know if it has not been reverted.
Please review it when you get a chance. Thank you

adamleff · 2017-06-23T16:01:35Z

test/unit/resources/elasticsearch_test.rb

+      _(resource.version).must_equal ["5.4.1"]
+    end
+
+      it 'Verify elasticsearch node mlockall state' do


Indentation lines 16-34 is off.. should be in line with the block above in lines 11-14.

adamleff · 2017-06-23T16:01:59Z

test/unit/resources/elasticsearch_test.rb

+require 'inspec/resource'
+
+describe 'Inspec::Resources::Elasticsearch' do
+  describe 'elasticsearch' do


This feels like a duplicative describe block... can we remove this?

adamleff · 2017-06-26T15:57:59Z

lib/resources/elasticsearch.rb

+# copyright: 2017
+# author: Rony Xavier, [email protected]
+# author: Aaron Lippold, [email protected]
+# license: All rights reserved


Please remove this line. InSpec is released under Apache 2.0. We have a pending PR to remove this line from all our files (acknowledging that you probably copy/pasted this from another existing file 🙂 ).

adamleff · 2017-06-26T15:58:08Z

test/unit/resources/elasticsearch_test.rb

+# encoding: utf-8
+# copyright: 2017
+# author: Rony Xavier, [email protected]
+# license: All rights reserved


Please remove this line. InSpec is released under Apache 2.0. We have a pending PR to remove this line from all our files (acknowledging that you probably copy/pasted this from another existing file 🙂 ).

adamleff · 2017-06-30T15:15:20Z

@rx294 just a heads up on this PR, it now has merge conflicts. Be sure to rebase your branch on the latest master and address those issues. One is on www/Gemfile.lock which you should just pull out of your commit since your PR shouldn't touch that file. :)

…icsearch_resource Signed-off-by: Aaron Lippold <[email protected]>

Signed-off-by: Rony Xavier <[email protected]>

adamleff

@rx294 I may not have cycles to give this a thorough review until I return from my vacation, but perhaps the other maintainers might.

However, right out of the gate, I notice that your change still deletes the Gemfile.lock file and adds it to the .gitignore file. Neither of these changes can be accepted in this PR.

Signed-off-by: Rony Xavier <[email protected]>

…icsearch_resource Signed-off-by: Aaron Lippold <[email protected]>

Signed-off-by: Rony Xavier <[email protected]>

adamleff

Great work, let's just tidy this up!

adamleff · 2017-08-07T14:49:53Z

lib/resources/elasticsearch.rb

+  class Elasticsearch < Inspec.resource(1)
+    name 'elasticsearch'
+    desc "Use the Elasticsearch InSpec audit resource to test the Elasticsearch
+    configuration settings. The data is extract from the live elastic search


Lines 51-53, please indent 2 spaces

adamleff · 2017-08-07T14:50:21Z

lib/resources/elasticsearch.rb

+          its('name') { should_not include 'node_name' }
+      end
+      elasticsearch.nodes.os.each do |nodeos|
+      	describe nodeos do


66-68, needs one more space

adamleff · 2017-08-07T14:50:57Z

lib/resources/elasticsearch.rb

+      	end
+      end
+      elasticsearch.nodes.version.each do |node_version|
+      	describe node_version do


71-73, fix indentation, and please git rid of that pesky tab on line 72 :)

adamleff · 2017-08-07T14:51:18Z

lib/resources/elasticsearch.rb

+          its('path.conf') {should cmp '/etc/elasticsearch'}
+        end
+      end
+		  elasticsearch.nodes.where{name == 'package-centos-72' }.settings.each do |node_settings|


Line 80 - more tabs! You're killing me... slowly... 🙂

adamleff · 2017-08-07T14:52:14Z

lib/resources/elasticsearch.rb

+        "
+
+    def initialize(url = 'http://localhost:9200/_nodes/')
+      return skip_resource 'Package `curl` not avaiable on the host' unless inspec.package('curl').installed?


Change to:

unless inspec.command('curl').exist?

adamleff · 2017-08-07T14:53:18Z

lib/resources/elasticsearch.rb

+      if command.stderr =~ /Failed to connect/
+        return skip_resource 'Connection refused please check ip and port provided'
+      end
+      @content = JSON.parse(command.stdout)


Protect against a failed JSON parse to avoid a Ruby exception unwinding the whole InSpec run.

Perhaps this, and the few lines that follow, should be broken out into a helper method.

def initialize # blah blah @content = read_es_data(url) end def read_es_data(url) # call curl # handle error, skip_resource if curl fails @content = JSON.parse(curl_output) rescue JSON::ParserError => e skip_resource "Couldn't parse ES data: #{e.message}" end

adamleff · 2017-08-07T15:02:13Z

lib/resources/elasticsearch.rb

+        node.node_id = node_id
+        node.plugin_list = plugin_list(node)
+        node.module_list = module_list(node)
+        node.cluster = node.settings.cluster.name


Suggestion to think about, should this be cluster_name?

And for sake of clarity, I would set this from node_data vs. setting it from itself...

node.cluster_name = node_data['settings']['cluster']['name']

adamleff · 2017-08-07T15:03:02Z

lib/resources/elasticsearch.rb

+        node.cluster = node.settings.cluster.name
+        @nodes.push(node)
+      end
+    rescue JSON::ParserError => _e


rescue JSON::ParserError

adamleff · 2017-08-07T15:03:33Z

lib/resources/elasticsearch.rb

+        @nodes.push(node)
+      end
+    rescue JSON::ParserError => _e
+      return Hashie::Mash.new({})


Hashie::Mash.new

adamleff · 2017-08-07T15:04:25Z

lib/resources/elasticsearch.rb

+    def plugin_list(node)
+      plugins_list = []
+      node.plugins.each do |plugins|
+        plugins_list.push(plugins.name)


plugins_list << plugins.name

For your education only :)

…ippold/inspec into al/elasticsearch_resource

Signed-off-by: Rony Xavier <[email protected]>

rx294 · 2017-08-15T14:24:15Z

@adamleff hey Adam this PR is ready...although looks like one of the Travis tests are failing for an unrelated issue. Thank you

adamleff · 2017-08-15T18:07:57Z

lib/resources/elasticsearch.rb

+    def read_es_data(url)
+      cmd = inspec.command("curl #{url}")
+      if !cmd.exit_status.zero?
+        return skip_resource "Error using the curl #{url}"


Perhaps as a follow-up to this PR, I'd suggest adding the stderr from the command to this message in hopes that it will help the user troubleshoot:

return skip_resource "Error fetching Elastcsearch data from #{url}: #{cmd.stderr}"

Thank you @adamleff that makes more sense.

adamleff

@rx294 this looks good, just one thing that we need to clean up in the read_es_data method re: error handling. I don't think we'll ever get to one of your error handling steps because of the way the method is written.

adamleff · 2017-08-15T18:09:36Z

lib/resources/elasticsearch.rb

+      if !cmd.exit_status.zero?
+        return skip_resource "Error using the curl #{url}"
+      end
+      if cmd.stderr =~ /Failed to connect/


If curl fails, it will catch at line 97 above and then we'll return. I don't think you'll ever get to this part of your method if it failed to connect.

If you want to provide a specific "connection refused" skip message, you will likely need to move lines 100-102 above line 97, and let the if statement at line 97 be a "catch-all error except connection refused events" handler. Make sense?

Thank you for the catch. That makes sense.

Signed-off-by: Rony Xavier <[email protected]>

rx294 · 2017-08-20T01:25:01Z

@adamleff I am getting a travisci error as below:

example inheritance profile#test_0004_ensure json/check command do not fetch remote profiles if vendored [/home/travis/build/chef/inspec/test/functional/inspec_vendor_test.rb:61]:

It looks unrelated to the elasticsearch resource, please let me know if it is not.

Thank you

adamleff

Super-close, @rx294 -- just some doc fixes and a discussion about the default URL. Thanks!

adamleff · 2017-08-25T13:27:43Z

lib/resources/elasticsearch.rb

+      end
+      elasticsearch.nodes.os.each do |nodeos|
+        describe nodeos do
+          its('name'){ should_not cmp 'MacOS' }


Need space between ) and {

adamleff · 2017-08-25T13:28:09Z

lib/resources/elasticsearch.rb

+      cluster using the curl command `curl localhost:9200/_nodes/`. The resource
+      makes uses of FilterTable and its functionality can be used "
+
+    example "


Can you please add a newline between each describe block so it's clearer and consistent with other documentation? Thank you!

adamleff · 2017-08-25T13:28:26Z

lib/resources/elasticsearch.rb

+      end
+      elasticsearch.nodes.version.each do |node_version|
+        describe node_version do
+          it{ should be > '1.2.0' }


Space needed between it and {

adamleff · 2017-08-25T13:28:37Z

lib/resources/elasticsearch.rb

+          it{ should be > '1.2.0' }
+        end
+      end
+      elasticsearch.nodes.where{os.name == 'Linux' }.settings.each do |node_settings|


Space needed between where and {

adamleff · 2017-08-25T13:28:59Z

lib/resources/elasticsearch.rb

+      end
+      elasticsearch.nodes.where{os.name == 'Linux' }.settings.each do |node_settings|
+        describe node_settings do
+          its('path.conf') {should cmp '/etc/elasticsearch'}


Please add wrapper spaces within the braces...

{ should cmp '/etc/elasticsearch' }

adamleff · 2017-08-25T13:29:11Z

lib/resources/elasticsearch.rb

+      end
+      elasticsearch.nodes.where{name == 'package-centos-72' }.settings.each do |node_settings|
+        describe node_settings do
+          its('path.conf') {should cmp '/etc/elasticsearch'}


Please add wrapper spaces within the braces...

{ should cmp '/etc/elasticsearch' }

Done. Thank you @adamleff , I should have known better by now haha

adamleff · 2017-08-25T13:30:24Z

lib/resources/elasticsearch.rb

+      end
+        "
+
+    def initialize(url = 'http://localhost:9200/_nodes/')


Any reason to include the _nodes part here? I think perhaps this should be the base URL for wherever Elasticsearch lives, and then we can call /_nodes within the resource. That way if we want to hit other endpoints later, such as /_cluster/health, we don't have to rework this.

The _nodes part is important because it exposes all the settings we are exposing using the resource and our parsers are expecting the json structure the '_nodes' curl request returns.

@rx294 that's exactly my point. Your resource depends on hitting /_nodes to do its job, but that is not the top-level URL to an Elasticsearch node/cluster. You are shifting an implementation detail responsibility onto the consumer of your resource.

You should ask expect the user to give you the top-level URL to their cluster, and then you as the resource author should tack on the /_nodes endpoint to the URL before you start making curl calls. Otherwise, you are forcing users to know that detail... and in the future, if we need to retrieve data from different endpoints (such as /_cluster or /_cat, we don't have to do janky regsub or break backward compatibility.

adamleff · 2017-08-25T13:31:43Z

test/unit/resources/elasticsearch_test.rb

+        _(node_roles).must_include 'master'
+      end
+    end
+    resource_with_url = load_resource('elasticsearch','http://localhost:9200/_nodes/')


Let's test with a non-default URL. This really isn't testing anything other than our ability to pass in a second argument. :)

Signed-off-by: Rony Xavier <[email protected]>

adamleff · 2017-08-28T11:16:57Z

test/unit/resources/elasticsearch_test.rb

@@ -32,7 +32,7 @@
        _(node_roles).must_include 'master'
      end
    end
-    resource_with_url = load_resource('elasticsearch','http://localhost:9200/_nodes/')
+    resource_with_url = load_resource('elasticsearch','http://localhost:9200/_nodes/ -u es_admin:password')


This is not what I meant... that's not part of the URL, that's now a command flag you pass to curl, but in the future, this resource may use a different method of fetching an HTTP endpoint.

It's possible to have elasticsearch clusters on different hostnames and different URIs. For example:

http://mydatacenter.mycompany.biz/myelasticsearch

... in which case, your resource would fetch from http://mydatacenter.mycompany.biz/myelasticsearch/_nodes

…icsearch_resource

Signed-off-by: Adam Leff <[email protected]>

adamleff · 2017-09-07T19:18:13Z

Status as I see it today: my concern about the user needing to supply /_nodes in their URL still needs to be addressed as does my concern about the way we're testing a non-standard URL. This is not yet ready to be re-reviewed.

Signed-off-by: Rony Xavier <[email protected]>

…ippold/inspec into al/elasticsearch_resource

…ippold/inspec into al/elasticsearch_resource Signed-off-by: Rony Xavier <[email protected]>

Signed-off-by: Rony Xavier <[email protected]>

rx294 · 2017-10-02T18:28:56Z

Hey @adamleff . I have made the updates. Please review it when you get a chance. Thank you!

Signed-off-by: Rony Xavier <[email protected]>

adamleff

@rx294 I only looked at it briefly, and this is closer, but I believe you made a decision that will hinder some users' ability to use it.

Specifically, you eliminated passing a URL and instead opted for parameters es_host and es_port. This means users to have Elasticsearch installed on a machine with a non-root URI (i.e. http://myhost:9201/elasticsearch) will not be able to use this resource. We should really go back to using URIs instead of parameterizing the host and port

Also, we should use better parameter names - there is no need to use the es_ prefix since the parameters are specific to this resource. Let's try to use clear and easy-to-understand parameter names.

adamleff · 2017-10-03T22:46:15Z

docs/resources/elasticsearch.md.erb

+
+* `es_ip` elasticsearch ip address, default : 0.0.0.0
+* `es_port` elasticsearch port address, default : 9200
+* `es_user` elasticsearch user name, default : nil


No need to prefix with es_ - use username

adamleff · 2017-10-03T22:46:25Z

docs/resources/elasticsearch.md.erb

+* `es_ip` elasticsearch ip address, default : 0.0.0.0
+* `es_port` elasticsearch port address, default : 9200
+* `es_user` elasticsearch user name, default : nil
+* `es_pass` elasticsearch user password, default : nil


No need to prefix with es_ - use password

adamleff · 2017-10-03T22:47:04Z

docs/resources/elasticsearch.md.erb

+* `es_port` elasticsearch port address, default : 9200
+* `es_user` elasticsearch user name, default : nil
+* `es_pass` elasticsearch user password, default : nil
+* `https(bool)` elasticsearch connection protocol, default : true


No need to have this as a parameter - just accept a full URI to the elasticsearch top-level

adamleff · 2017-10-03T22:47:42Z

docs/resources/elasticsearch.md.erb

+* `es_user` elasticsearch user name, default : nil
+* `es_pass` elasticsearch user password, default : nil
+* `https(bool)` elasticsearch connection protocol, default : true
+* `self_signed_cert(bool)` elasticsearch uses self-signed certificate , default : false


There are more reasons you need to disable SSL certificate validation other than a self-signed cert is in use. For consistency with other resources, please name this ssl_verify and you can default to true

adamleff · 2017-10-03T23:11:59Z

docs/resources/elasticsearch.md.erb

+
+where
+
+* `es_ip` elasticsearch ip address, default : 0.0.0.0


We should accept a URI and not an IP/port - see my top-level review comment.

Good point. Done.

adamleff · 2017-10-03T23:25:51Z

lib/resources/elasticsearch.rb

+        return skip_resource "Couldn't parse ES data: #{e.message}"
+      end
+
+      return skip_resource "Security Exception: #{@content['error']}" unless @content['error'].nil?


Can you explain this? What's a "security exception"?

I have modified it to show status of the error from elasticsearch

adamleff · 2017-10-03T23:26:23Z

lib/resources/elasticsearch.rb

+
+      cmd = inspec.command("curl #{url}")
+      return skip_resource 'Connection refused please check ip and port provided' if cmd.stderr =~ /Failed to connect/
+      return skip_resource "Connection refused Peer's Certificate issuer is not recognized" if cmd.stderr =~ /Peer's Certificate issuer is not recognized/


Is this necessary? The stderr will be displayed in the skip_resource message in line 112.

This would help capture the reason of failure.

Right, but the reason for the failure you're matching on ("Peer's Certificate issue is not recognized") is in the stderr output already, and it will be output in line 112. The skip message you're returning in this line 111 is not adding any additional value that wouldn't be handled properly in line 112.

Oh i remmember, the Peer certificate stderr is this big ugly block
"% Total % Received % Xferd Average Speed Time Time Time Current\n Dload Upload Total Spent Left Speed\n\r 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0\r 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0\ncurl: (60) Peer's Certificate issuer is not recognized.\nMore details here: http://curl.haxx.se/docs/sslcerts.html\n\ncurl performs SSL certificate verification by default, using a "bundle"\n of Certificate Authority (CA) public keys (CA certs). If the default\n bundle file isn't adequate, you can specify an alternate file\n using the --cacert option.\nIf this HTTPS server uses a certificate signed by a CA represented in\n the bundle, the certificate verification probably failed due to a\n problem with the certificate (it might be expired, or the name might\n not match the domain name in the URL).\nIf you'd like to turn off curl's verification of the certificate, use\n the -k (or --insecure) option.\n"

I figured this would be a cleaner skip message of a known possible error.

That's a great reason. Let's add a comment above this line that explains why we're specifically catching this one error type.

Signed-off-by: Rony Xavier <[email protected]>

adamleff · 2017-10-12T06:59:52Z

@rx294 I still think there are some issues with this that I've unsuccessfully tried to communicate (i.e. the URL should be an argument rather than an item in the option hash), and there are still issues (i.e. the default URL shouldn't use 0.0.0.0 or https by default), so I'm going to adopt your PR with attribution and try and push it across the finish line. I'm traveling for the next couple of days, so I should be able to work on this sometime next week. Unfortunately, it's just taking too much time to try and address the remaining issues through the PR back-and-forth process.

I'll close this PR with an new updated one once I've done so. Thanks.

rx294 · 2017-10-13T20:34:56Z

Got it. thank you adam

@rx294

This is a new resource for testing an Elasticsearch cluster. It operates by fetching the `_nodes` endpoint from a given Elasticsearch node and collects data about each node in a cluster, even if there's only a single node. This work is based on inspiration from an initial PR #1956 submitted by @rx294. Signed-off-by: Rony Xavier <[email protected]> Signed-off-by: Aaron Lippold <[email protected]> Signed-off-by: Adam Leff <[email protected]>

adamleff · 2017-10-20T17:17:39Z

Superseded by PR #2261 - thanks for your work on this.

@rx294

* new resource: elasticsearch resource, test cluster/node state This is a new resource for testing an Elasticsearch cluster. It operates by fetching the `_nodes` endpoint from a given Elasticsearch node and collects data about each node in a cluster, even if there's only a single node. This work is based on inspiration from an initial PR #1956 submitted by @rx294. Signed-off-by: Rony Xavier <[email protected]> Signed-off-by: Aaron Lippold <[email protected]> Signed-off-by: Adam Leff <[email protected]> * Reduce mock data on non-default tests Signed-off-by: Adam Leff <[email protected]>

rx294 force-pushed the al/elasticsearch_resource branch from 5fbbbc3 to 12003d7 Compare June 22, 2017 22:58

aaronlippold force-pushed the al/elasticsearch_resource branch 3 times, most recently from 5b16a2a to 5ed9d31 Compare June 23, 2017 03:19

elasticsearch resources

1530818

Signed-off-by: Rony Xavier <[email protected]> Signed-off-by: Aaron Lippold <[email protected]>

aaronlippold force-pushed the al/elasticsearch_resource branch from 5ed9d31 to 1530818 Compare June 23, 2017 03:40

adamleff suggested changes Jun 23, 2017

View reviewed changes

adamleff suggested changes Jun 26, 2017

View reviewed changes

adamleff added the Type: New Feature Adds new functionality label Jun 27, 2017

aaronlippold and others added 2 commits July 7, 2017 09:28

Merge branch 'master' of https://github.com/chef/inspec into al/elast…

efe96e6

…icsearch_resource Signed-off-by: Aaron Lippold <[email protected]>

Performed recommended corrections

280ac9d

Signed-off-by: Rony Xavier <[email protected]>

adamleff suggested changes Jul 12, 2017

View reviewed changes

rx294 force-pushed the al/elasticsearch_resource branch from 7e7e0fb to 0a4e5b9 Compare July 15, 2017 01:52

Gemlock file fix

848d595

Signed-off-by: Rony Xavier <[email protected]>

rx294 force-pushed the al/elasticsearch_resource branch from 0a4e5b9 to 848d595 Compare July 15, 2017 01:56

aaronlippold force-pushed the al/elasticsearch_resource branch from 01c73b7 to efe96e6 Compare July 18, 2017 16:56

Fix .gitignore file

24059ab

Signed-off-by: Rony Xavier <[email protected]>

rx294 changed the title ~~Initial commit of elasticsearch resource,~~ elasticsearch resource Jul 25, 2017

Merge branch 'master' of https://github.com/chef/inspec into al/elast…

b63aed7

…icsearch_resource Signed-off-by: Aaron Lippold <[email protected]>

rx294 force-pushed the al/elasticsearch_resource branch from b63aed7 to 7112051 Compare July 29, 2017 23:53

Fix .gitignore file

8d206b2

Signed-off-by: Rony Xavier <[email protected]>

rx294 force-pushed the al/elasticsearch_resource branch from 7112051 to 8d206b2 Compare August 7, 2017 14:21

adamleff suggested changes Aug 7, 2017

View reviewed changes

aaronlippold force-pushed the al/elasticsearch_resource branch from 8d206b2 to b63aed7 Compare August 9, 2017 12:40

rx294 added 2 commits August 14, 2017 00:56

Merge branch 'al/elasticsearch_resource' of https://github.com/aaronl…

1147661

…ippold/inspec into al/elasticsearch_resource

Updates as per review

bcb8ecb

Signed-off-by: Rony Xavier <[email protected]>

adamleff reviewed Aug 15, 2017

View reviewed changes

adamleff suggested changes Aug 15, 2017

View reviewed changes

Updates based on remarks

ac8f117

Signed-off-by: Rony Xavier <[email protected]>

adamleff suggested changes Aug 25, 2017

View reviewed changes

Updates are per review

d1ecdee

Signed-off-by: Rony Xavier <[email protected]>

adamleff reviewed Aug 28, 2017

View reviewed changes

aaronlippold and others added 2 commits August 28, 2017 13:18

Merge branch 'master' of https://github.com/chef/inspec into al/elast…

042177a

…icsearch_resource

Resolve lib/resource.rb conflict

1e4c0eb

Signed-off-by: Adam Leff <[email protected]>

rx294 added 7 commits October 2, 2017 12:56

updates

3b8609b

Signed-off-by: Rony Xavier <[email protected]>

Merge branch 'master' into al/elasticsearch_resource

8ed6402

Merge branch 'master' into al/elasticsearch_resource

bc3a86b

Signed-off-by: Rony Xavier <[email protected]>

Merge branch 'al/elasticsearch_resource' of https://github.com/aaronl…

1449e17

…ippold/inspec into al/elasticsearch_resource

Merge branch 'al/elasticsearch_resource' of https://github.com/aaronl…

2643484

…ippold/inspec into al/elasticsearch_resource Signed-off-by: Rony Xavier <[email protected]>

Merge branch 'al/elasticsearch_resource' of https://github.com/aaronl…

0931a5e

…ippold/inspec into al/elasticsearch_resource Signed-off-by: Rony Xavier <[email protected]>

minor fixes

396bfd3

Signed-off-by: Rony Xavier <[email protected]>

Added tests

b819c3a

Signed-off-by: Rony Xavier <[email protected]>

adamleff suggested changes Oct 3, 2017

View reviewed changes

rx294 added 5 commits October 9, 2017 10:09

Updates as per PR Review

b65322e

Signed-off-by: Rony Xavier <[email protected]>

Updates

e515d05

Signed-off-by: Rony Xavier <[email protected]>

fix lint errors

253decf

Signed-off-by: Rony Xavier <[email protected]>

added code comments

cc5a6fb

Signed-off-by: Rony Xavier <[email protected]>

updates

e4449da

Signed-off-by: Rony Xavier <[email protected]>

adamleff mentioned this pull request Oct 20, 2017

new resource: elasticsearch resource, test cluster/node state #2261

Merged

adamleff closed this Oct 20, 2017

elasticsearch resource #1956

elasticsearch resource #1956

Conversation

rx294 commented Jun 22, 2017

adamleff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamleff commented Jun 30, 2017

adamleff left a comment

Choose a reason for hiding this comment

adamleff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rx294 commented Aug 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamleff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rx294 commented Aug 20, 2017

adamleff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamleff commented Sep 7, 2017

rx294 commented Oct 2, 2017

adamleff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment