WIP: Vj/clean up formatter #1315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full JSON formatter was using the start step to setup the profiles_info. I moved that to a memozied method so that the first time it is called it will be created. Signed-off-by: Franklin Webber <[email protected]>
Cleans up the #stop action on the JSON formatter by creating more methods that memoize values or provide values through a method interface. There is still more that can be done with the whole mapping examples to controls through profiles. Signed-off-by: Franklin Webber <[email protected]>
A lot of the work in #flush_current_control is acting on the control. I am starting the flip of the control and bringing those messages being sent originating from a control class itself. Signed-off-by: Franklin Webber <[email protected]>
vjeffrey
force-pushed
the
vj/clean-up-formatter
branch
2 times, most recently
from
8b46f65 to
2a64442
Compare
chris-rock
force-pushed
the
vj/clean-up-formatter
branch
from
2a64442 to
2e25027
Compare
The profiles will display the controls with their results and then display the examples not associated with any control but within the profile. Signed-off-by: Franklin Webber <[email protected]>
|
Is this PR superseded by #1331? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are my changes on top of the changes you are proposing @vjeffrey.
THIS IS A WORK-IN-PROGRESS. Still committing work.