Improve google_project#to_s output #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The google_project resource documentation indicates that resources are
instantiated with :project, but the google_project was storing the value
of :name for use with `#to_s`. This inconsistency leads to InSpec output
like the following:
✔ Project should exist
✔ Project name should eq "dev-host"
✔ Project parent.type should eq "folder"
✔ Project parent.id should eq "743996818495"
This commit adds :project as a fallback value for `@display_name,`
ensuring that google_projects will format correctly in the InSpec
report.
Signed-off-by: Adrien Thebo <[email protected]>
skpaterson
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The google_project resource documentation indicates that resources are
instantiated with :project, but the google_project was storing the value
of :name for use with
#to_s. This inconsistency leads to InSpec outputlike the following:
This commit adds :project as a fallback value for
@display_name,ensuring that google_projects will format correctly in the InSpec
report.