Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for service account and related resources #47

Merged
merged 6 commits into from
Sep 5, 2018

Conversation

skpaterson
Copy link

More details below:

  • Added google_service_accounts and google_service_account_key(s) resources
  • Refactored google_service_account to also use the fully-qualified name of the service account
  • Update tf to set the account ID field for service account to use display name string
  • Renamed generic_iam_service_account control to google_service_account for consistency
  • Improved documentation for google_project
  • Update README with new service account resources. Improve display name for service account and add email as a filterable parameter for service accounts.
  • Minor documentation fixes in kms crypto keys and key rings. Added helper to get rotation period in crypto key.

Stuart Paterson added 6 commits August 29, 2018 10:18
- Added google_service_accounts and google_service_account_key(s) resources
- Refactored google_service_account to also use the fully-qualified name of the service account
- Update tf to set the account ID field for service account to use display name string
- Renamed generic_iam_service_account control to google_service_account for consistency
- Improved documentation for google_project

Signed-off-by: Stuart Paterson <[email protected]>
…e for service account and add email as a filterable parameter for service accounts.

Signed-off-by: Stuart Paterson <[email protected]>
Signed-off-by: Stuart Paterson <[email protected]>
…per to get rotation period in crypto key.

Signed-off-by: Stuart Paterson <[email protected]>
@skpaterson skpaterson changed the title Updates for service account resource Updates for service account and related resources Aug 29, 2018
Copy link
Contributor

@davymcaleer davymcaleer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @skpaterson - thank you

Copy link
Contributor

@russellseymour russellseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@russellseymour russellseymour merged commit f6add3a into master Sep 5, 2018
@russellseymour russellseymour deleted the service-accounts branch September 5, 2018 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants