This resource is a singleton and is only driven off one unique key, "… #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name". Removed "display_name" as a call option as that caused a crash due to a bug in the code. "display_name" is not gauranteed to be unique. Signed-off-by: Adrian Daniels <[email protected]>
skpaterson
suggested changes
Dec 13, 2019
libraries/google_organization.rb
Outdated
| catch_gcp_errors do | ||
| @organization = @gcp.gcp_project_client.get_organization(opts[:name]) | ||
| create_resource_methods(@organization) | ||
| if opts[:name] |
There was a problem hiding this comment.
Thanks for this @lhasadreams - this if statement is slightly problematic because the resource will silently do nothing if the name is not provided.
Could you replace this with something like the following:
raise Inspec::Exceptions::ResourceFailed, "google_organization is missing mandatory property 'name'" if opts[:name].nil?
There was a problem hiding this comment.
Sure, that makes a lot of sense - code updated
…inspec exception Signed-off-by: Adrian Daniels [email protected]
skpaterson
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name".
Removed "display_name" as a call option as that caused a crash due to a bug in the code.
"display_name" is not gauranteed to be unique.
Signed-off-by: Adrian Daniels [email protected]
Description
Stops the crashing when called using display_name.
Alters the code and docs to only use name.