Changes to nclient4 and nclient6 from our testing phase
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmazzini
reviewed
Sep 2, 2024
| @@ -1,3 +1,5 @@ | |||
| replace github.com/insomniacslk/dhcp => gitlab.com/Vitrifi/insomniacslk-dhcp v0.0.1-cne | |||
There was a problem hiding this comment.
Hello. Thank you for comment. It's what we used internally to get it working quick and dirty. It'm in a process of cleaning that up.
As is it may not meet open source project standards yet.
There was a problem hiding this comment.
By the way, that Pull Request was supposed to be inside our fork, but it seems I've done it wrongly.
Maybe better to split in different PRs. |
Signed-off-by: Jaroslaw Mroz <[email protected]>
Signed-off-by: Jaroslaw Mroz <[email protected]>
Signed-off-by: Jaroslaw Mroz <[email protected]>
Signed-off-by: Jaroslaw Mroz <[email protected]>
Signed-off-by: Jaroslaw Mroz <[email protected]>
Signed-off-by: Jaroslaw Mroz <[email protected]>
jrsmroz
force-pushed
the
cne-rebase-to-master
branch
from
cdb1fe0 to
abaae81
Compare
|
Closing this pull request. It was not supposed to be opened into insomniacslk:master yet. We will attempt to commit our changes back after the cleanup. Once again, I'm sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts Vitirify fork of insomniacslk/dhcp.
Changes include:
nclient6nclient4Core functionality of dhcp message handling was not touches.