Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graph snapshot processing #183

Merged
merged 11 commits into from
Dec 20, 2023

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Dec 14, 2023

Closes #182

Merge after insightsengineering/tern#1158

This should standardize the generation of graph snapshots across different systems and hopefully fix the failing integration tests for graph snapshot differences.

Note: kmg01 snapshots will be fixed after g_km is refactored.

@edelarua edelarua added the sme label Dec 14, 2023
Copy link
Contributor

github-actions bot commented Dec 14, 2023

Unit Tests Summary

    1 files  2 suites   1m 1s ⏱️
  24 tests 0 ✔️   24 💤 0
290 runs  0 ✔️ 290 💤 0

Results for commit a65ee12.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 14, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
graph-snaps 💔 $7.99$ $+1.97$ $+4$ $+4$ $0$ $0$
markdown-snaps 💔 $50.31$ $+1.03$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
graph-snaps 💔 $3.25$ $+2.36$ plot_v1
graph-snaps 💀 $0.16$ $-0.16$ plot_v1_and_v2
graph-snaps 💀 $0.09$ $-0.09$ table_v6

Results for commit 88f986c

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job Emily! I also read the main PR with rtables2gg. Fantastic! :)

@Melkiades Melkiades merged commit fa118d9 into main Dec 20, 2023
@Melkiades Melkiades deleted the 182_fix_graph_snaps@1109_refactor_g_forest@main branch December 20, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update graph test snapshots to process as ggplot objects
2 participants