[Bug]: ADAT02 data setup forces all patients to be post-baseline evaluable

[manciniedoardo]

What happened?

There is a line in the data setup for ADAT02 where ADAPBLPFL is set to "Y" everywhere, and it's marked as a temp fix:

# Ensure character variables are converted to factors and empty strings and NAs are explicit missing levels.
adsl <- df_explicit_na(adsl)
adab <- df_explicit_na(adab) %>%
  mutate(ADPBLPFL = "Y") %>% # temp fix
  filter(
    ADPBLPFL == "Y",
    !PARAM %in% c(
      "NAB interpreted per sample result",
      "NAB Status of a patient",
      "Treatment enhanced ADA"
    )
  ) 

I assume this shouldn't be there? Took me a while to figure out what was wrong with my data!

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct.

Contribution Guidelines

• I agree to follow this project's Contribution Guidelines.

Security Policy

• I agree to follow this project's Security Policy.

[shajoezhu]

hi @Qi Liu ***@***.***> Just want to check, we used that line because of the data right? can we remove it in real cases? Best Joe

…

On Thu, 13 Feb 2025 at 22:01, Edoardo Mancini ***@***.***> wrote: What happened? There is a line in the data setup for ADAT02 where ADAPBLPFL is set to "Y" everywhere, and it's marked as a temp fix: # Ensure character variables are converted to factors and empty strings and NAs are explicit missing levels. adsl <- df_explicit_na(adsl) adab <- df_explicit_na(adab) %>% mutate(ADPBLPFL = "Y") %>% # temp fix filter( ADPBLPFL == "Y", !PARAM %in% c( "NAB interpreted per sample result", "NAB Status of a patient", "Treatment enhanced ADA" ) ) I assume this shouldn't be there? Took me a while to figure out what was wrong with my data! Relevant log output *No response* Code of Conduct - I agree to follow this project's Code of Conduct. Contribution Guidelines - I agree to follow this project's Contribution Guidelines. Security Policy - I agree to follow this project's Security Policy. — Reply to this email directly, view it on GitHub <#301>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4FP7JLKFUGHG6TGGAGKTL2PSQSDAVCNFSM6AAAAABXCIFOKKVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA2TCMJSHEYDCNA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> [image: manciniedoardo]*manciniedoardo* created an issue (insightsengineering/tlg-catalog#301) <#301> What happened? There is a line in the data setup for ADAT02 where ADAPBLPFL is set to "Y" everywhere, and it's marked as a temp fix: # Ensure character variables are converted to factors and empty strings and NAs are explicit missing levels. adsl <- df_explicit_na(adsl) adab <- df_explicit_na(adab) %>% mutate(ADPBLPFL = "Y") %>% # temp fix filter( ADPBLPFL == "Y", !PARAM %in% c( "NAB interpreted per sample result", "NAB Status of a patient", "Treatment enhanced ADA" ) ) I assume this shouldn't be there? Took me a while to figure out what was wrong with my data! Relevant log output *No response* Code of Conduct - I agree to follow this project's Code of Conduct. Contribution Guidelines - I agree to follow this project's Contribution Guidelines. Security Policy - I agree to follow this project's Security Policy. — Reply to this email directly, view it on GitHub <#301>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4FP7JLKFUGHG6TGGAGKTL2PSQSDAVCNFSM6AAAAABXCIFOKKVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA2TCMJSHEYDCNA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Joe Zhu, PhD NEST SME engineering lead | Principal data scientist Data Science Acceleration (DSX) PD Data & Statistical Sciences (PD DSS) PD Shanghai, Roche (China) Holding Ltd. 1100 Longdong Avenue, Shanghai, 201203 China E: ***@***.*** https://go.roche.com/nest https://go.roche.com/nest_trainings https://go.roche.com/asknest *Upcoming OOTO:* *30/Sep/2024 - 8/Oct/2024*