-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update install guide; add getting help; pkg name lowercase #890
Conversation
Code Coverage Summary
Diff against main
Results for commit: 706f6b0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Co-authored-by: Aleksander Chlebowski <[email protected]> Signed-off-by: Pawel Rucki <[email protected]>
README.md
Outdated
@@ -1,4 +1,4 @@ | |||
# Teal: Interactive Exploratory Data Analysis with Shiny Web-Applications <a href='https://insightsengineering.github.io/teal/'><img src="man/figures/teal.png" align="right" height="139" style="max-width: 100%;"/></a > | |||
# teal: Interactive Exploratory Data Analysis with Shiny Web-Applications <a href='https://insightsengineering.github.io/teal/'><img src="man/figures/teal.png" align="right" height="139" style="max-width: 100%;"/></a > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about removing image and keeping duck as icon :D
BTW. thin about that mojo accepts emoji as file extension. I wonder if our files could be similar hehe
# teal: Interactive Exploratory Data Analysis with Shiny Web-Applications <a href='https://insightsengineering.github.io/teal/'><img src="man/figures/teal.png" align="right" height="139" style="max-width: 100%;"/></a > | |
# teal 🦆: Interactive Exploratory Data Analysis with Shiny Web-Applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with emoji icon but would like to keep the hexagon badge also
Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: Pawel Rucki <[email protected]>
Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: Pawel Rucki <[email protected]>
UPDATE: Added Usage section with gif recording |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :+1
I made a mistake in this PR. Please have a look also at the follow-up PR here: #894 |
pak
and notremotes
because this is also standard for pkgs from tidyverse or r-lib.browseVignettes(package = "teal")
with url as I believe that most of users will read README from within pkgdown webpage.Please add your feedback. I would like to treat this PR as a reference to the issue for other package updates.