Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

382 rename internal functions #868

Merged
merged 8 commits into from
Jul 24, 2023
Merged

Conversation

chlebowa
Copy link
Contributor

Related to this issue

disassemble_slices function is removed, will use as.list.teal_slices from teal.slice
reassemble_slices function is remove, will use as.teal_slices from this package
as.teal_slices function lifted from teal.slice is renamed to list_to_teal_slices

@chlebowa chlebowa added the core label Jul 21, 2023
@chlebowa chlebowa marked this pull request as ready for review July 21, 2023 12:31
@chlebowa chlebowa requested a review from m7pr July 21, 2023 12:31
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    16 suites   12s ⏱️
171 tests 171 ✔️ 0 💤 0
341 runs  341 ✔️ 0 💤 0

Results for commit dec298d.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -----------------------------------------------------------------------------
R/dummy_functions.R                 88      75  14.77%   12-110
R/example_module.R                  18       9  50.00%   23-26, 29-33
R/get_rcode_utils.R                 46       1  97.83%   49
R/include_css_js.R                  24       0  100.00%
R/init.R                            76      30  60.53%   150-151, 169-176, 181-202, 214-216
R/module_filter_manager.R          102      29  71.57%   62-70, 79-84, 217, 222-235
R/module_nested_tabs.R             171      16  90.64%   59, 108, 112-113, 127-134, 162, 214, 236, 269
R/module_snapshot_manager.R        139     103  25.90%   71-82, 109-118, 122-134, 136-143, 149-164, 177-200, 203-214, 217-223, 250-272
R/module_tabs_with_filters.R        66       2  96.97%   134, 176
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    164      12  92.68%   49, 52, 155-156, 206-207, 227-230, 232, 236
R/modules_debugging.R               18      18  0.00%    25-44
R/modules.R                        108      11  89.81%   314-357
R/reporter_previewer_module.R       16       2  87.50%   23, 27
R/show_rcode_modal.R                20      20  0.00%    16-37
R/tdata.R                           41       2  95.12%   146, 172
R/teal_reporter.R                   60       5  91.67%   65, 116-117, 120, 137
R/teal_slices.R                     45       0  100.00%
R/utils.R                           21       8  61.90%   38-47
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     62      39  37.10%   111-375
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1361     391  71.27%

Diff against main

Filename                       Stmts    Miss  Cover
---------------------------  -------  ------  --------
R/module_snapshot_manager.R       -9       0  -4.51%
R/teal_slices.R                   +5       0  +100.00%
TOTAL                             -4       0  -0.08%

Results for commit: e32b4a6

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@chlebowa chlebowa requested a review from gogonzo July 24, 2023 06:54
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wundabar

@chlebowa chlebowa merged commit 6ce8ad7 into main Jul 24, 2023
@chlebowa chlebowa deleted the 382_rename_internal_functions@main branch July 24, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants