723 default header@main

[chlebowa]

Closes this issue.

Changed default values of header and footer in init from tags$p("Add title here") to tags$p().

[Melkiades]

Lgtm! Thanks for taking care of this. It was quite ugly. Is it not breaking downstream?

[chlebowa]

Lgtm! Thanks for taking care of this. It was quite ugly. Is it not breaking downstream?

I checked a few tmc apps and they work when header = tags$p(). I will double check with this branch installed.

[github-actions]

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18       9  50.00%   23-26, 29-33
R/get_rcode_utils.R                 45       0  100.00%
R/include_css_js.R                  24       0  100.00%
R/init.R                            24       2  91.67%   190-191
R/module_nested_tabs.R             161       7  95.65%   57, 97, 101-102, 137, 188, 240
R/module_tabs_with_filters.R        68       1  98.53%   162
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    111       5  95.50%   49, 52, 155-156, 180
R/modules_debugging.R               18      18  0.00%    37-56
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/tdata.R                           41       2  95.12%   146, 172
R/utils.R                           13       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     62      39  37.10%   107-368
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              868     183  78.92%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  -------
R/init.R         +2       0  +0.76%
TOTAL            +2       0  +0.05%

Results for commit: cd6008a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[chlebowa]

I have a curious situation: example apps from teal and tmc fail on this branch and on main but work on filter_panel_refactor@main and its children.

Warning: Error in eventReactiveValueFunc: attempt to apply non-function
  101: active_datanames
   99: renderUI
   98: func
   85: renderFunc
   84: output$teal-main_ui-filter_panel-overview-table
    3: runApp
    2: print.shiny.appobj
    1: <Anonymous>

This requires some investigation.

[github-actions]

Unit Tests Summary

    1 files    12 suites   15s ⏱️
143 tests 143 ✔️ 0 💤 0 ❌
283 runs  283 ✔️ 0 💤 0 ❌

Results for commit 4621ef7.

[chlebowa]

This requires some investigation.

Fixed by reinstalling NEST.