Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add teal.gallery ref to readme #810

Merged
merged 2 commits into from
Mar 10, 2023
Merged

add teal.gallery ref to readme #810

merged 2 commits into from
Mar 10, 2023

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Mar 9, 2023

No description provided.

@pawelru pawelru added the core label Mar 9, 2023
@pawelru pawelru enabled auto-merge (squash) March 9, 2023 18:36
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

badge

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  ------------------------------
R/dummy_functions.R                 74      61  17.57%   12-95
R/example_module.R                  18       9  50.00%   23-26, 29-33
R/get_rcode_utils.R                 52       2  96.15%   94, 99
R/get_rcode.R                      137      54  60.58%   74, 81, 86, 211-277
R/include_css_js.R                  24       0  100.00%
R/init.R                            22       2  90.91%   188-189
R/module_nested_tabs.R             161       7  95.65%   57, 97, 101-102, 137, 188, 240
R/module_tabs_with_filters.R        68       1  98.53%   162
R/module_teal_with_splash.R         33       2  93.94%   65, 77
R/module_teal.R                    111       5  95.50%   49, 52, 155-156, 180
R/modules_debugging.R               18      18  0.00%    37-56
R/modules.R                        101       8  92.08%   341-366
R/reporter_previewer_module.R       12       2  83.33%   18, 22
R/show_rcode_modal.R                20      20  0.00%    17-38
R/tdata.R                           41       2  95.12%   146, 172
R/utils.R                           13       0  100.00%
R/validate_inputs.R                 32       0  100.00%
R/validations.R                     62      39  37.10%   107-368
R/zzz.R                             11       7  36.36%   3-14
TOTAL                             1010     239  76.34%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3fdd5ed

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Unit Tests Summary

    1 files    13 suites   14s ⏱️
154 tests 154 ✔️ 0 💤 0
301 runs  301 ✔️ 0 💤 0

Results for commit 7730ff5.

♻️ This comment has been updated with latest results.

Signed-off-by: Pawel Rucki <[email protected]>
@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented Mar 10, 2023

Should we also add to tmg and tmc, t.o and t.g?

@@ -50,6 +50,8 @@ A lot of the functionality of the `teal` framework derives from the following pa

See these packages for more information about how to use the different parts of the `teal` framework.

Please see [`teal` gallery](https://github.com/insightsengineering/teal.gallery) and [TLG Catalog](https://github.com/insightsengineering/tlg-catalog) to see examples of `teal` apps.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm you might be right but currently all our references are to the GH (not GitHubPages) so I wanted to stay consistent to the currently existing approach

@pawelru
Copy link
Contributor Author

pawelru commented Mar 10, 2023

Should we also add to tmg and tmc, t.o and t.g?

tmc, tern are done
tmg pr opened

@pawelru pawelru merged commit aa56913 into main Mar 10, 2023
@pawelru pawelru deleted the pawelru-patch-1 branch March 10, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants