803 data reactivity@main

[nikolas-burkoff]

Closes #803

Lots of TODOs in the code - especially the make id's unique of modules in teal::init

library(teal)

delay_module <- function(label = "delay", sleep_time = 0.5) {
  module(label = label, server = function(id, data) {
    moduleServer(id, function(input, output, session) {

      observeEvent(data[[1]](), {
        print(sprintf("trigger for module %s of %f", label, sleep_time))
        Sys.sleep(sleep_time)
        print(sprintf("trigger for module %s of %f completed", label, sleep_time))
      })

    })
  })
}


my_iris <- iris
my_iris$Species[1] <- NA

app <- init(
  data = teal_data(dataset("IRIS", my_iris )),
  modules = modules(
    delay_module("A"),
    modules(label = "Tab2", delay_module("B")),
    modules(label = "Tab3", delay_module("C"), delay_module("D")),
    delay_module("E")    
  )
)

runApp(app)

[nikolas-burkoff]

best to do this after the reporter module has been added

[mhallal1]

I tested this branch with the exploratory app, it seems that the reactivity is not triggered there when changing the tabs of modules so none of the modules is calculated at the beginning or when changing.

[gogonzo]

I tested this branch with the exploratory app, it seems that the reactivity is not triggered there when changing the tabs of modules so none of the modules is calculated at the beginning or when changing.

I had the same but then I've tried individual modules and they are working. Problem found in the sample apps is that they have first tab which doesn't need data. When I removed front-page and dataviewer modules everything was fine.

[mhallal1]

I tested this branch with the exploratory app, it seems that the reactivity is not triggered there when changing the tabs of modules so none of the modules is calculated at the beginning or when changing.

I had the same but then I've tried individual modules and they are working. Problem found in the sample apps is that they have first tab which doesn't need data. When I removed front-page and dataviewer modules everything was fine.

Agreed, plus some shinyvalidate errors in regression and bivariate modules, investigating these.

[nikolas-burkoff]

Also I think a few modules (PCA, outliers,...) aren't happy

[donyunardi]

I also experienced the same thing that were mentioned.
I guess we can close this without merging in favor of #806?

[mhallal1]

I also experienced the same thing that were mentioned. I guess we can close this without merging in favor of #806?

If we get agreement on #806 then we will close this one.

[github-actions]

Unit Tests Summary

    1 files    13 suites   12s ⏱️
150 tests 147 ✔️ 0 💤 2 ❌ 1 🔥
294 runs  289 ✔️ 0 💤 4 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit 1c702d1.

[nikolas-burkoff]

Closed in favor of #806