-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hashing #774
add hashing #774
Conversation
Code Coverage Summary
Diff against main
Results for commit: 0e02c7a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the NEWS we should mention not only have the hashes been moved here but that we now use rlang instead of digest (this is important if the hash algorithms produce different answers - I'm not sure they are)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know what you think about these:
Co-authored-by: Nikolas Burkoff <[email protected]> Signed-off-by: Mahmoud Hallal <[email protected]>
just double check the internal roxygen mentions hashes for the funcitons which now have them |
closes #751
The dataset are being hashed using
rlang::hash
in:data_to_datasets
when usingqenv
get_rcode
when using chunkschunks
-
calculate_hashes
function has been created to be used in both places.-the filtering is not returned in
get_datasets_code
now but rather inget_rcode
anddatasets_to_data
.-messages and warnings calls are now returned in
get_datasets_code
instead of character strings.Please test with
chunks
andqenv
examples from tmg, tmc ...Also closes #752