Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full input cycle - teal #648

Closed
wants to merge 37 commits into from
Closed

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented May 30, 2022

transfer the #637 to the pre-release based PR

Now all modules have a full initial shiny input cycle.
It is dane with an empty Tab selection when the teal app is initialize and then using js code to click the first tab.
More than that we delayed when the module server is executed, when its tab is clicked.

@Polkas Polkas added the core label May 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

Code Coverage Summary

Filename                         Stmts    Miss  Cover    Missing
-----------------------------  -------  ------  -------  -------------------------------------------
R/default_filter.R                   7       7  0.00%    17-27
R/dummy_functions.R                 78      65  16.67%   12-99
R/example_module.R                  17      17  0.00%    18-34
R/get_rcode_utils.R                 52      11  78.85%   42-51, 94, 99
R/get_rcode.R                      145      99  31.72%   71-74, 85-148, 195, 201-202, 233-284
R/include_css_js.R                  20       0  100.00%
R/init.R                            39      21  46.15%   171, 182-183, 236-257
R/log_app_usage.R                   38      38  0.00%    34-119
R/logging.R                         13      13  0.00%    11-28
R/module_nested_tabs.R              84       4  95.24%   53, 137, 190, 196
R/module_tabs_with_filters.R        52       0  100.00%
R/module_teal_with_splash.R         33       2  93.94%   62, 74
R/module_teal.R                    123      20  83.74%   49, 52, 142-143, 156-162, 168-174, 198, 232
R/modules_debugging.R               19      19  0.00%    41-60
R/modules.R                         82      10  87.80%   208, 268, 371-396
R/reporter_previewer_module.R       12       2  83.33%   17, 21
R/show_rcode_modal.R                20      20  0.00%    17-38
R/utils.R                            6       0  100.00%
R/validations.R                     62      39  37.10%   103-355
R/zzz.R                             11       7  36.36%   3-14
TOTAL                              913     394  56.85%

Results for commit: a315a3acab5f171d4f72ee71248a13e000cf7503

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2022

Unit Tests Summary

    1 files    10 suites   9s ⏱️
  94 tests   94 ✔️ 0 💤 0
198 runs  198 ✔️ 0 💤 0

Results for commit 032c1f0.

♻️ This comment has been updated with latest results.

@Polkas
Copy link
Contributor Author

Polkas commented May 30, 2022

@mhallal1 could you share with us your findings when profiling the apps after this change. thanks

@Polkas Polkas requested a review from gogonzo May 30, 2022 08:18
@mhallal1
Copy link
Collaborator

Running the exploratory app in profvis, I get the following:

  1. on main:
    Screenshot from 2022-05-30 11-25-01

  2. on 443_rcycle@main:
    Screenshot from 2022-05-30 11-26-46

What I noticed is that a couple of modules, not all, are called before init in both cases.

@insights-engineering-bot insights-engineering-bot deleted the branch pre-release June 9, 2022 17:25
@Polkas Polkas deleted the 443_inputcycle@pre-release branch June 10, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants