-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the definition of "transform" in the vignettes #1489
Conversation
Code Coverage Summary
Diff against main
Results for commit: c1314dc Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 27 suites 10m 49s ⏱️ Results for commit c1314dc. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit 02e5df3 ♻️ This comment has been updated with latest results. |
Hey @vedhav I think it is solid. The name of the vignette changed, and this changed also needs to be reflected in tmc and in tmg, where those packages link to teal vignette. I can handle that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedhav I think this is solid. Left 2-3 minor comments, but this is good to go
Closes #1475
Customizing Module Output
vignette is now calledTransform Module Output
As we introduce a new term "customize" and it would be best to use the same term "transform" that we se to transform the
teal_data
objectData Transformations as Shiny Module
is now calledTransform Input Data
This name was appropriate at the time of writing the vignette when transformation done using shiny module was only possible in one place, now that is not the case and we have two places where data is transformed using shiny module. And from the user's perspective the main thing showcased in this vignette is about transforming the input data.